Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98332
Return-Path: <anatol.php@belski.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 39933 invoked from network); 20 Feb 2017 15:50:20 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 20 Feb 2017 15:50:20 -0000
Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
X-PHP-List-Original-Sender: anatol.php@belski.net
X-Host-Fingerprint: 85.214.73.107 klapt.com  
Received: from [85.214.73.107] ([85.214.73.107:33756] helo=h1123647.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id DF/9D-15063-7301BA85 for <internals@lists.php.net>; Mon, 20 Feb 2017 10:50:15 -0500
Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006)
	id AACB1784BC2; Mon, 20 Feb 2017 16:50:11 +0100 (CET)
Received: from w530phpdev (p54A77314.dip0.t-ipconnect.de [84.167.115.20])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id 5F2F6782FB8;
	Mon, 20 Feb 2017 16:50:09 +0100 (CET)
To: "'Dmitry Stogov'" <dmitry@zend.com>,
	"'Nikita Popov'" <nikic@php.net>,
	"'Xinchen Hui'" <laruence@php.net>,
	"'Joe Watkins'" <krakjoe@php.net>
Cc: "'PHP internals list'" <internals@lists.php.net>
References: <005501d28917$c472d9c0$4d588d40$@belski.net> <MWHPR02MB2477C79CFAC186FBF613577EBF5D0@MWHPR02MB2477.namprd02.prod.outlook.com> <00a001d28922$4e320500$ea960f00$@belski.net>
In-Reply-To: <00a001d28922$4e320500$ea960f00$@belski.net>
Date: Mon, 20 Feb 2017 16:50:05 +0100
Message-ID: <00e501d28b91$03b33280$0b199780$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGdeWbJLEby5/ZsPBjtYvSAiRoltAL1j84dAWF3nYWhuXJA8A==
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: Thread safe interned strings
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> > For now, I see one missing part - opcache can't work completely out of
> > the
> box,
> > because its interned string related functions are wrapped with #ifndef
> > ZTS
> >
> Oh, indeed. Getting to this part now then :)
> 

The Opcache support is done now. Additional things that are done

- some startup/shutdown sequence refactoring was required in zend.c, to
mitigate shutdown issues with Opcache
- CG(zend_string) was removed, instead there is a global variable
- fixed phpdbg integration

With this, looks like it's ready for the next review round. I'm doing some
load tests in between.

Thanks

Anatol