Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98297
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NroSFbiLnHqEJE9UXwsTrutB3OSo2sysn0j=zFRHyD2-w@mail.gmail.com>
References: <CA+kxMuS7BJyJOo0p-+8CF+bKy5oTLWLJVygA=u89iNHPXjENRQ@mail.gmail.com>
 <CAFMT4Nqiv0ThgVRza2oaReDhGzSN0hOtWLyW=qDvc3yVNhd_AA@mail.gmail.com>
 <CA+kxMuQZTLKDDbbJXDjJTkkPCK_0Jfwrek-jVg94x9wEoqQnFw@mail.gmail.com>
 <CA+kxMuQfW_3E7CRDDjZ=HTJS6LcsAgfU8dgRvarMDtWO6443Xg@mail.gmail.com>
 <CAFMT4NoC6BBbP=ifeeYdSjOBNiiUpj_q3fP_EJTN-h62hov6Qw@mail.gmail.com> <CAFMT4NroSFbiLnHqEJE9UXwsTrutB3OSo2sysn0j=zFRHyD2-w@mail.gmail.com>
Date: Wed, 15 Feb 2017 08:52:37 +0100
Message-ID: <CADyq6sLCE-Y0b+fxnjKVhrUKMfSycuHGfE3VPKqviOhfVQfN+A@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Dan Ackroyd <danack@basereality.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11405bace0eab505488cf652
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance
From: ocramius@gmail.com (Marco Pivetta)

--001a11405bace0eab505488cf652
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Levi,


On 14 Feb 2017 10:20 p.m., "Levi Morrison" <levim@php.net> wrote:

On Tue, Feb 14, 2017 at 2:14 PM, Levi Morrison <levim@php.net> wrote:
> On Tue, Feb 14, 2017 at 11:55 AM, Dan Ackroyd <danack@basereality.com>
wrote:
>> Hi Levi,
>>
>> On 24 November 2016 at 08:58, Dan Ackroyd <danack@basereality.com> wrote=
:
>>> Hi Levi,
>>>
>>> On 23 November 2016 at 01:25, Levi Morrison <levim@php.net> wrote:
>>>
>>>> For instance enumerations (or enums) are one possible type I can see u=
s
>>>> adding that may not be objects.
>>>
>>> I very much look forward to the RFC for enums, and have for some time.
>>> When are you thinking of submitting it for discussion and voting?
>>
>> I can understand your concerns. At the same time, I hope you can
>> understand that people won't want to put off introducing features that
>> they want in the meantime.
>>
>> I think if you were able to give a timeline for when an Enum RFC could
>> be introduced, before the PHP 7.2 release, we could talk about whether
>> it would be right to hold off on this RFC for now.
>>
>> Otherwise I suggest Micha=C5=82 updates the voting options, and we open =
the
>> voting in a week or so.
>>
>> cheers
>> Dan
>
> Let me clarify that I'm not against this object variance; there is
> nothing intrinsic about object variance that prevents enums (or
> typedefs/type aliases). Rather it's *how* it is achieving that
> variance that is an issue. This is something that should ship along
> with full covariance/contravariance and not be a special case which
> may unintended side-effects later (such as preventing enums without
> breaking BC). Does that make sense?

Here's a concrete compatibility concern. Let's assume we have the
following code:

    interface Factory {
        function make(...$args): object;
    }

    class FooFactory {
        function make(...$args): Foo;
    }

Currently the engine would not have to know anything about Foo to know
if it is a sub-type of object. It would not need to require it to even
be defined.

However, if at some point in the future we add non-object types it may
now error or autoload.



Since the engine is clueless about types until autoloading happens, this is
easily solvable by providing a marker syntax for non-object hints. For
instance `function foo() : enym:MyEnum {}`

The current (and valid) assumption by both the engine and userland
reflectors is that anything after the `:` in a return type declaration is
one of:

 * bool
 * array
 * int
 * float
 * string
 * callable
 * void
 * $classOrInterfaceName

Regardless of this RFC, and considered that `object` is an already reserved
keyword, you can't use the same syntax for enum types anyway, since you're
going to break a crapton of userland code.


The way to avoid the compatibility concern is to implement this
feature the same way we wold implement full covariance, which would
similarly need to know about the types involved.

Does that make more sense as to why the assumption that unknown types
are object types is an issue?

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php


Given inline comments above, can we archive the enum discussion?

--001a11405bace0eab505488cf652--