Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98284
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.218.66 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <FBB16247-67F1-4A34-8AF1-D25DF8C2DC61@gmail.com>
References: <4CD4DCCC-6643-4A66-B6AD-4BF0EF89FDA9@gmail.com>
 <CAESVnVpFmLuJkSG-znmOyRDh2evcEiv3ZXzQkhoet4r9hekM=A@mail.gmail.com>
 <1FC170E6-5207-45F3-8DF7-8B50787DCCA7@gmail.com> <CAESVnVro1_896Kc-1UjbGHixBbdVm2dc-uN0ycAB-pDeZrW4NA@mail.gmail.com>
 <FBB16247-67F1-4A34-8AF1-D25DF8C2DC61@gmail.com>
Date: Fri, 10 Feb 2017 18:31:07 -0500
Message-ID: <CAESVnVrnLC6_oAQR-wcDb9zhtZzkHjV-43mQ1YJSzrvChpiuvQ@mail.gmail.com>
To: Ben RUBSON <ben.rubson@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Improve (disable|enable)_functions #65386
From: pollita@php.net (Sara Golemon)

On Fri, Feb 10, 2017 at 4:09 PM, Ben RUBSON <ben.rubson@gmail.com> wrote:
> I was talking more specifically about the following :
> "php_admin_value disable_functions mydisfunction"
> phpinfo() shows mydisfunction as locally disabled,
> but in reality can still be used.
>
Uh... that sounds like a bug.  That should absolutely not be the case
based on the code I'm looking at here.
Unless you're thinking disable_functions should work on userspace
code.  It's only meant for disabling internal/extension functions.

> Perhaps initial init time could be a little bit longer, but to the benefit
> of non-slowed requests.
> OK, understood, thank you !
>
Perhaps.  Again, not dug in enough to be confident we could get where
you want to be without slowing down a hot codepath.

> Any way to "officially" add these requests (#65386) to the development list ?
>
That's what the bug report is.  If someone comes up with a good
solution, I'm sure it'll be RFC'd, but we need a good solution first.

-Sara