Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98215
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Niklas Keller'" <me@kelunik.com>
Cc: "'Leigh'" <leight@gmail.com>,
	"'Michael Wallner'" <mike@php.net>,
	"'PHP Internals'" <internals@lists.php.net>,
	"'Bob Weinand'" <bwoebi@php.net>,
	"'Daniel Lowrey'" <rdlowrey@php.net>
References: <CANUQDCgObDtxvaEs4LM3N4VXXQfDT_KOM-e1FuaP__t1gsB1Yw@mail.gmail.com> <CANUQDChc=_VrnzhYGhfg14+msLCOqgAs2wja_cady9nsWnPfJw@mail.gmail.com> <146cbb21-72cf-ed65-095a-43a7420482fc@php.net> <CANUQDCgPoot7UoyoUiaFmG54kxDHFRCz53OpuE5pUHRphDepGA@mail.gmail.com> <02c901d2684e$d1ee2a30$75ca7e90$@belski.net> <CANUQDCgRufuER6LoZrukUSHAQ-ktE00TK4m62UFuv7s=FigN0Q@mail.gmail.com> <CAPwsocHsjVyBfGC6d-0=U=J-Xy8rruoJ92fH6OSQ8AQKi3EJfQ@mail.gmail.com> <CANUQDCjuOw117vjtn2buD59Jsu5j-wA54Ab97mnfz7+Z+p=3wQ@mail.gmail.com> <013d01d26e80$5c916f30$15b44d90$@belski.net> <CANUQDCg95za_N0rDD9rFKHWV_GBAFDQYNt5o7TJnK0wPmq3Amg@mail.gmail.com> <CANUQDCh1AGBnX5OHXpXn8YXspUDeTUo3s19_BeYUnjLfgzkYHw@mail.gmail.com>
In-Reply-To: <CANUQDCh1AGBnX5OHXpXn8YXspUDeTUo3s19_BeYUnjLfgzkYHw@mail.gmail.com>
Date: Mon, 6 Feb 2017 13:33:09 +0100
Message-ID: <019301d28075$2efdce40$8cf96ac0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQG2APfuj27eyiyn6X74ZL08hYdWAAF/HnI7ArG79kgBt17lbwLNShRmARVka/sCTNF/hgIT1qRnAmSbHhQBwapXtwFFxQcfoPgcJtA=
Content-Language: en-us
Subject: RE: [PHP-DEV] Fwd: Monotonic Time
From: anatol.php@belski.net ("Anatol Belski")

Hi Niklas,

> -----Original Message-----
> From: Niklas Keller [mailto:me@kelunik.com]
> Sent: Sunday, February 5, 2017 8:19 PM
> To: Anatol Belski <anatol.php@belski.net>
> Cc: Leigh <leight@gmail.com>; Michael Wallner <mike@php.net>; PHP =
Internals
> <internals@lists.php.net>; Bob Weinand <bwoebi@php.net>; Daniel Lowrey
> <rdlowrey@php.net>
> Subject: Re: [PHP-DEV] Fwd: Monotonic Time
>=20
> I have implemented a `hrtime()` function which allows access to the =
system's
> monotonic time in nanoseconds.
>=20
Nice for the start.

>=20
> https://github.com/php/php-src/compare/master...kelunik:hrtime
>=20
>=20
> Feedback is very welcome.
>=20
> I'm not sure whether we should allow a parameter for the time unit or =
just let
> the user do the simple calculation.
>=20
I'd see this integration a bit different, as the goal is to put it into =
the core.  Here some quick points to maybe think about

- on the m4 side, symbols need to be checked
- the PHP internal and user stuff should be integrated tight into the =
timer.c file,=20
- a finer usage with the concrete platform should be taken care of, thus =
avoiding unnecessary function calls and conversions back/forth as you =
can use
- there might be a situation, where the monotonic API could be used =
internally before modules are initialized
- the symbols exported need to be renamed, probably prefix with =
php_monotonic_*, like php_monotonic_timer_current(), etc.
- but aso, probably not all the symbols should be exported

With the names and API, probably some more clarity should be. AFM, the =
low level units should be exposed, rather than a concrete time. Also, =
the name hrtime() is probably not much speaking. Maybe these three?

sys_get_monotonic_ticks()
sys_get_monotonic_freq()
sys_get_monotonic_nanotime() or even - sys_get_monotonic_time(int $unit =
=3D NANOSECOND)

Regarding to "sys_get_*" scheme with these. But in general, probably =
nanoseconds were enough for the general case and fast, the pure ticks =
were for the advanced usage.

In general, probably for the core it should be done a more robust way, =
some parts on the original lib should get more error checks and =
improved. It would be probably more handy to discuss the further on the =
PR page.

Regards

Anatol