Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:982
Return-Path: <marcus.boerger@t-online.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 51922 invoked from network); 19 Apr 2003 18:47:59 -0000
Received: from unknown (HELO mailout05.sul.t-online.com) (194.25.134.82)
  by pb1.pair.com with SMTP; 19 Apr 2003 18:47:59 -0000
Received: from fwd03.sul.t-online.de 
	by mailout05.sul.t-online.com with smtp 
	id 196xNW-0001BO-01; Sat, 19 Apr 2003 20:47:58 +0200
Received: from baumbart.post.rwth-aachen.de (520072483730-0001@[80.142.151.239]) by fwd03.sul.t-online.com
	with esmtp id 196xNK-1ceAr2C; Sat, 19 Apr 2003 20:47:46 +0200
Reply-to:marcus.boerger@post.rwth-aachen.de
Message-ID: <5.1.0.14.2.20030419204707.029f6568@pop.t-online.de>
X-Mailer: QUALCOMM Windows Eudora Version 5.1
Date: Sat, 19 Apr 2003 20:47:38 +0200
To: Timm Friebe <thekid@thekid.de>
Cc: Sterling Hughes <sterling@bumblebury.com>,internals@lists.php.net
In-Reply-To: <1050774385.5685.13.camel@localhost>
References: <1050769070.827.1367.camel@hasele>
 <1050769070.827.1367.camel@hasele>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
X-Sender: 520072483730-0001@t-dialin.net
Subject: Re: [PHP-DEV] [patch] final use only for methods
From: marcus.boerger@t-online.de ((Marcus =?iso-8859-1?Q?B=F6rger?=))

At 19:46 19.04.2003, Timm Friebe wrote:
>On Sat, 2003-04-19 at 18:17, Sterling Hughes wrote:
> > The attached patch modifies zend_language_parser, having it generate a
> > compiler error when final is used on a class property (since we are only
> > allowing it for methods.)
>
>You could then also drop:
>
>if (parent_info->flags & ZEND_ACC_FINAL) {
>   zend_error(E_COMPILE_ERROR, "Cannot override final property %s::$%s",
>parent_ce->name, hash_key->arKey);
>}


Only the above. The other two are needed for method checks.

marcus