Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98184
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKws9z3+qrGner3K58rPqPdXW00YFCm4esrr5xhr6ettoRRVYA@mail.gmail.com>
References: <CAKws9z3+qrGner3K58rPqPdXW00YFCm4esrr5xhr6ettoRRVYA@mail.gmail.com>
Date: Sat, 4 Feb 2017 17:16:06 +0100
Message-ID: <CAF+90c-NseLsswpp+sOYj-ujJ3UYZOyMBodo1x3GoObcmcSNJw@mail.gmail.com>
To: Scott Arciszewski <scott@paragonie.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f403045f29d835dc140547b6b75b
Subject: Re: [PHP-DEV] [RFC] [VOTE] Libsodium as a core extension in PHP 7.2
From: nikita.ppv@gmail.com (Nikita Popov)

--f403045f29d835dc140547b6b75b
Content-Type: text/plain; charset=UTF-8

On Fri, Feb 3, 2017 at 9:44 PM, Scott Arciszewski <scott@paragonie.com>
wrote:

> I've opened the vote for the libsodium RFC.
>
> https://wiki.php.net/rfc/libsodium
>
> See https://externals.io/thread/626 for the previous discussion topics.
>
> The vote closes at 21:00 UTC (4 PM Eastern Time) next Friday.
>

I just took a very quick look at the extension source. One question: Right
now it throws recoverable fatal errors all over the place. Why doesn't it
use exceptions instead? We replaced (to the most part) use of recoverable
fatals with exceptions in PHP 7 and reintroducing them in this quantity
would be highly dubious to me.

Also a question on maintenance: If this extension is bundled, will the
source compatibility with PHP 5 be removed, or do you plan on keeping a
single code-base for the bundled extension and PECL, with support for PHP
5? None of the current bundled extensions do this, as it is a significant
maintenance burden.

Thanks,
Nikita

--f403045f29d835dc140547b6b75b--