Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:98170 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45431 invoked from network); 4 Feb 2017 06:30:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Feb 2017 06:30:47 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:49214] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 74/DF-38491-51575985 for ; Sat, 04 Feb 2017 01:30:47 -0500 Received: (qmail 108381 invoked by uid 89); 4 Feb 2017 06:30:42 -0000 Received: from unknown (HELO mail-qt0-f180.google.com) (yohgaki@ohgaki.net@209.85.216.180) by 0 with ESMTPA; 4 Feb 2017 06:30:42 -0000 Received: by mail-qt0-f180.google.com with SMTP id w20so61126916qtb.1 for ; Fri, 03 Feb 2017 22:30:41 -0800 (PST) X-Gm-Message-State: AMke39llIDR6B2xyyNbX2/n4eit8i6pNa+yb1Dp4PtzTYvTJkp5AmXeoTqcdEmEwzxRzsZm1yja+n+vt+bWWqQ== X-Received: by 10.200.35.105 with SMTP id b38mr614662qtb.1.1486189835525; Fri, 03 Feb 2017 22:30:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.19.232 with HTTP; Fri, 3 Feb 2017 22:29:54 -0800 (PST) In-Reply-To: References: Date: Sat, 4 Feb 2017 15:29:54 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Nikita Popov Cc: Andrey Andreev , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a11402d943748ae0547ae895c Subject: Re: [PHP-DEV] [Discussion] HKDF From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11402d943748ae0547ae895c Content-Type: text/plain; charset=UTF-8 On Sat, Feb 4, 2017 at 2:48 PM, Yasuo Ohgaki wrote: > string hash_hkdf(string algo, string ikm [, int length = 0, string info = > '', string salt = '']) I copied and pasted this proto from the source. It's wrong. Correct one is string hash_hkdf(string algo, string ikm [, int length = 0 [, string info = '' [, string salt = '']]]) so my proposal is string hash_hkdf(string algo, string ikm, string salt [, string info = '' [, int length = 0]]) - Set salt to NULL if salt cannot be used, reject null string as invalid. I will change my mind if there is convincing logical reason(s) not to do this. I suppose there isn't. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11402d943748ae0547ae895c--