Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:9817
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <20040511144841.71396.qmail@web13424.mail.yahoo.com>
Date: Tue, 11 May 2004 07:48:41 -0700 (PDT)
To: internals@lists.php.net
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: 5.0.0RC2: Why is DEBUG_FILE_UPLOAD always on now?
From: msisolak@yahoo.com (Michael Sisolak)

For 5.0.0RC2 in main/rfc1867.c this code was introduced:

#define DEBUG_FILE_UPLOAD ZEND_DEBUG

As a result even Release builds of 5.0.0RC2 are reporting file upload
errors as E_NOTICE errors.  This includes when a form is submitted with
an optional file upload field that has not been specified (you always
get the error "Notice: No file uploaded in Unknown on line 0" which
can't be disabled without lowering the error level).

Was this change made on purpose, or was leaving this line in a mistake?
 It would seem that something like:

#if ZEND_DEBUG
#define DEBUG_FILE_UPLOAD
#else
#undef DEBUG_FILE_UPLOAD
#endif

would make more sense instead.  Having a form with an empty upload
field shouldn't be a PHP system level error should it?  Isn't that
really something for the script to handle?

Michael Sisolak
msisolak@yahoo.com


	
		
__________________________________
Do you Yahoo!?
Win a $20,000 Career Makeover at Yahoo! HotJobs  
http://hotjobs.sweepstakes.yahoo.com/careermakeover