Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98101
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <f9e12ef5-c721-d6cf-4726-f6e4a37bbdcd@fleshgrinder.com>
References: <f9e12ef5-c721-d6cf-4726-f6e4a37bbdcd@fleshgrinder.com>
Date: Tue, 31 Jan 2017 16:02:07 -0700
Message-ID: <CAObuZdv-L3x22ZiJDf5w=sfhv72FDcnc5-fC9voJ-Dx9GMDZKQ@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Cc: Adam Harvey <aharvey@php.net>
Content-Type: multipart/alternative; boundary=94eb2c034ca6da509105476beb23
Subject: Re: [PHP-DEV] [RFC] Comparable
From: derokorian@gmail.com (Ryan Pallas)

--94eb2c034ca6da509105476beb23
Content-Type: text/plain; charset=UTF-8

On Tue, Jan 31, 2017 at 3:48 PM, Fleshgrinder <php@fleshgrinder.com> wrote:

> Hi :)
>
> I have a few questions regarding the comparable RFC:
>
> https://wiki.php.net/rfc/comparable
>
> Couldn't find the thread in my history and thus cannot respond directly
> to any of the past threads. Maybe not that bad after more than a year of
> silence. :)
>
> My question might sound silly but I am genuinely interested in the
> explanation: why `compareTo` and not `comparedTo` as method name? Is it
> simply because of Java? To me it sounds kind of wrong:
>
>     if ($this->compareTo($other) === -1) { }
>
> Especially if we add a nice Ordering Enum with some real behavior to the
> game:
>
>     if ($this->compareTo($other)->isLess()) { }
>
> Compare this to:
>
>     if ($this->comparedTo($other)->isLess()) { }
>
> This gets close to what I would understand as proper English. Then again
> there might be valid reasons for the former name that I am not aware of?!?
>

I would say compareTo makes sense, because that's what you're asking the
method to do. Methods aren't usually past tense as it would seem weird.
Think about PDOStatement::fetch vs fetched, Exception::getMessage vs
gotMessage. Honestly I can't think of a single example of a past tense
method off the top of my head (doesn't meant they don't exist!). Even
functions and language constructs are present (echo, require, print).


>
> There are other things that I think should be added along with this RFC.
> However, I need to investigate a bit further first before going into
> detail here.
>
> --
> Richard "Fleshgrinder" Fussenegger
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--94eb2c034ca6da509105476beb23--