Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97944
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.171 as permitted sender)
MIME-Version: 1.0
Sender: nicolas.grekas@gmail.com
In-Reply-To: <CAF+90c8Wox0wadAVPsP83er=G9jbW__26yBWOFAsjB09rYVFJA@mail.gmail.com>
References: <CAF+90c8Wox0wadAVPsP83er=G9jbW__26yBWOFAsjB09rYVFJA@mail.gmail.com>
Date: Tue, 24 Jan 2017 10:44:22 +0100
Message-ID: <CAOWwgpkXehWa+8tW9UQ9qabUASRHNYjHfgwDUwk6OJB4yWHmEA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113bd5dc39fec30546d3f789
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 7.2
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--001a113bd5dc39fec30546d3f789
Content-Type: text/plain; charset=UTF-8

Hi Nikita, hi all,


    https://wiki.php.net/rfc/deprecations_php_7_2



I just realized that in Symfony, we use the $errcontext argument of error
handlers to work around the limitation of __toString not being able to
throw.

Excerpt from
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Debug/ErrorHandler.php#L439
:

                        // Here, we know trigger_error() has been called
from __toString().
                        // HHVM is fine with throwing from __toString() but
PHP triggers a fatal error instead.
                        // A small convention allows working around the
limitation:
                        // given a caught $e exception in __toString(),
quitting the method with
                        // `return trigger_error($e, E_USER_ERROR);` allows
this error handler
                        // to make $e get through the __toString() barrier.

This is a hack, but that's what the Debug component is about: leverage
several hacks and ship them as a set of useful experience-enhancers to devs.

In short, I'm all for deprecating $errcontext, and looking at the ongoing
vote it'll be accepted soon.

BUT, it would great to fix the inability of __toString to throw in 7.2 also.

Regards,
Nicolas

--001a113bd5dc39fec30546d3f789--