Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97938
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1484727448.3119.8.camel@toro.home>
References: <1484727448.3119.8.camel@toro.home>
Date: Mon, 23 Jan 2017 12:25:27 -0500
Message-ID: <CADxrgCNCVMOit8NjuCGn2+aCnOCeq=aFmYQk2CwtfP0SHF77_Q@mail.gmail.com>
To: Torsten Rosenberger <rosenberger@taoweb.at>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114633621dcb4f0546c64980
Subject: Re: [PHP-DEV] writing extensions best practice, pass an object as parameter
From: adambaratz@php.net (Adam Baratz)

--001a114633621dcb4f0546c64980
Content-Type: text/plain; charset=UTF-8

>
> but how can i pass the object from a private method of the PHP extension
>
class to the  setcallbackfunction as it is down in PHP with
>
> array(&$this, '_htmlentities')
>

I usually find reading the source for standard library functions to be
helpful for learning how to do things. array_map could help with capturing
a callable and then doing something with it:
https://github.com/php/php-src/blob/master/ext/standard/array.c#L6005

so the PHP Class with opcache ist equal faste as my extension.
> My goal was to write the class as an extension to get faster.
>

Is the constructor where the bulk of the computation happens? Given that
this is a templating tool, it's probably during render. My guess of what
you'd get out of rewriting in C is greater control over string manipulation
and related memory allocation.

That said, if you're hitting performance issues, I might suggest looking
into another templating tool that's more actively maintained. Extensions
are generally harder to maintain than userland code. If you succeed in
writing a faster version of this tool, this could turn into a "now you have
two problems" situation[1]. If at all possible, it'd be better to let an
existing community solve performance issues for you.

The last question should I use call_user_function or write this function
> in C.
>

Call the internal function directly for less overhead.

Hope this helps!

Adam

---
[1] http://regex.info/blog/2006-09-15/247

--001a114633621dcb4f0546c64980--