Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:97923 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76685 invoked from network); 22 Jan 2017 15:29:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jan 2017 15:29:14 -0000 Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.218.50 as permitted sender) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.218.50 mail-oi0-f50.google.com Received: from [209.85.218.50] ([209.85.218.50:35596] helo=mail-oi0-f50.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DC/05-00729-ACFC4885 for ; Sun, 22 Jan 2017 10:29:14 -0500 Received: by mail-oi0-f50.google.com with SMTP id j15so67808956oih.2 for ; Sun, 22 Jan 2017 07:29:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lerdorf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XQSESA59B5Dihhf9OhL8f/rcNCdIbcI9gcLq9oZNmHw=; b=RIf7Tw3GuP8RWs2IzH6/afCv2DPBo73vCMM4WwmjjRKx+G9h6RcqiZxvKHTLmtbZao Wjl73eDSQBuOib7K6vWxPOcM3nO4LEjVTtLNY9hFMzeuW3ots08SM1dkhzw2IsOXpXNW vReIVL1FEwqN1UwBD7mUTlwghOZZ4yOS1zRuUz4vsFAQJLcE4XA8/KHsYhCWBA2T7TRZ sxQpA7eEGezzy8bYEy/GG8cm8tJO616x5ml84xx7jORWcPE3BimwFnmX+ylWt4x6LI9g Z2V1ZjLl6ummGmfv2MYa35Hbw4A/d6IjeWHVlweYpj9ghiZEN13rlrR5CHX3Lr/aotl+ 6jcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XQSESA59B5Dihhf9OhL8f/rcNCdIbcI9gcLq9oZNmHw=; b=NXQOJAsVvlS2vBsrHqSViKHe49eE5RcJldjKekY9OIVFYJ0m7Z+VoSN32jN34Zecdh QY5OGp4mi2VT2DqroOihmZV41qzEdPnqHTZeo8a5kcZFkZL529G3avwl1B4ay40miShz ZmmC/ujrvMzAE9YxcFqHdTBmzFR4h2p/IYRPthsHlcqndcJegre1san8wREnyETqnlCL 7mt73+Zz+8vjNDjBAUna26v1tVnkewN2jclDqkdjn/9JoD/MUfgSIhAOP3KQopSYo02c WYut9uXahYSmKVAat7vMnemMThGcAGUYni+OcCybNJDcaYY1rYquGMISfF+vaoVHTBCt +PgA== X-Gm-Message-State: AIkVDXK0y/nUbnaEeM5gtiSVCdhIc/a9PdG+2cLMD6gkLF1Ua/LhaTC9HjTUQgHRbidZEb2xwZAsNz1mYmBnZQ== X-Received: by 10.202.240.4 with SMTP id o4mr4915067oih.189.1485098952021; Sun, 22 Jan 2017 07:29:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.121.84 with HTTP; Sun, 22 Jan 2017 07:28:31 -0800 (PST) In-Reply-To: References: <4bc04e8d-d546-a671-6c88-cb44af2e0529@gmx.de> Date: Sun, 22 Jan 2017 07:28:31 -0800 Message-ID: To: "Christoph M. Becker" Cc: Nikita Popov , PHP internals Content-Type: multipart/alternative; boundary=94eb2c0943ee7df3d10546b08b53 Subject: Re: [PHP-DEV] pdo_sqlite fd leak From: rasmus@lerdorf.com (Rasmus Lerdorf) --94eb2c0943ee7df3d10546b08b53 Content-Type: text/plain; charset=UTF-8 On Sat, Jan 21, 2017 at 5:22 PM, Rasmus Lerdorf wrote: > On Sat, Jan 21, 2017 at 4:47 PM, Christoph M. Becker > wrote: >> >> Anyhow, the SQLite3 documentation states[1]: >> >> | The sqlite3_prepare_v2() and sqlite3_prepare16_v2() interfaces are >> | recommended for all new programs. The two older interfaces are >> | retained for backwards compatibility, but their use is discouraged. >> >> Isn't that reason enough to switch to sqlite3_prepare_v2() ASAP? Note >> that this is documented at least for more than nine years[2]! >> >> [1] >> [2] >> > org/c3ref/prepare.html> > > > Yes, but it also says that the behaviour is slightly different on an error > condition which could potentially affect peoples' code. Although it seems > like a subtle difference and only in the case of an error, so it should be > ok to change for 7.2. > Ok, I have switched pdo_sqlite to use sqlite3_prepare_v2() and sqlite3_close_v2() for PHP 7.2 --94eb2c0943ee7df3d10546b08b53--