Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97922
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.22 as permitted sender)
To: Rowan Collins <rowan.collins@gmail.com>, internals@lists.php.net
References: <840ab355-966f-7c49-a337-5335a5022de5@gmx.de>
 <def1df14-7516-9505-4982-a4e39bbe452c@gmail.com>
Message-ID: <20932f6e-4c5d-ad0d-2b90-66de3c0d1f4d@gmx.de>
Date: Sun, 22 Jan 2017 13:05:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <def1df14-7516-9505-4982-a4e39bbe452c@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: =?UTF-8?Q?Re:_[PHP-DEV]_imagepolygon=28=29_=e2=80=93_number_of_poin?=
 =?UTF-8?Q?ts?=
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 21.01.2017 at 19:11, Rowan Collins wrote:

> On 21/01/2017 17:42, Christoph M. Becker wrote:
>
>> In the long run (i.e. for PHP 8) I'd suggest to purge the $num_points
>> parameter altogether, relying solely on the number of $points given.
> 
> Since there's a 4th parameter ($color), what would "purge" mean in this
> case? Reducing the number of parameters to 3 would be very confusing,
> because existing code passing $num_points would be interpreted as
> passing that value as $color.
> 
> We could ignore the argument whatever value was provided; or we could
> document that it should be passed as null, and raise a warning if it's
> anything else; or we could ignore it if it matched the length of
> $points, and raise a warning or error if it didn't...

I haven't really though about how to do that, because PHP 8 is too far
away, and for now I'm interested in a clean solution that can be applied
to PHP 7(.2)

-- 
Christoph M. Becker