Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97919
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.218.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4bc04e8d-d546-a671-6c88-cb44af2e0529@gmx.de>
References: <CACXBjuiCfGt+eoX_rmCBQw3b9ns8J--R8+LCtp1cekKGghdD9Q@mail.gmail.com>
 <CAF+90c-pER=1Q-4UcQjWtGXB0PneCfM_5Kw5EquxVw_181yjMg@mail.gmail.com>
 <CACXBjuhY3Srkj=jgTVT8uTdFDqC66ybUuorarH9NNcsEfXZ_CQ@mail.gmail.com>
 <CACXBjuiK6=h+wqzGeWzxfR0EucToFENC28f_BNoG=UUBi1d+1A@mail.gmail.com> <4bc04e8d-d546-a671-6c88-cb44af2e0529@gmx.de>
Date: Sat, 21 Jan 2017 17:22:09 -0800
Message-ID: <CACXBjugKMASU0Tj778o44DGNe2jV83S0Q4RqbWugcULyn6VJMg@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113cf054ad567b0546a4b866
Subject: Re: [PHP-DEV] pdo_sqlite fd leak
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--001a113cf054ad567b0546a4b866
Content-Type: text/plain; charset=UTF-8

On Sat, Jan 21, 2017 at 4:47 PM, Christoph M. Becker <cmbecker69@gmx.de>
wrote:
>
> Anyhow, the SQLite3 documentation states[1]:
>
> | The sqlite3_prepare_v2() and sqlite3_prepare16_v2() interfaces are
> | recommended for all new programs. The two older interfaces are
> | retained for backwards compatibility, but their use is discouraged.
>
> Isn't that reason enough to switch to sqlite3_prepare_v2() ASAP?  Note
> that this is documented at least for more than nine years[2]!
>
> [1] <https://sqlite.org/c3ref/prepare.html>
> [2]
> <http://web.archive.org/web/20070701000000*/https://
> sqlite.org/c3ref/prepare.html>


Yes, but it also says that the behaviour is slightly different on an error
condition which could potentially affect peoples' code. Although it seems
like a subtle difference and only in the case of an error, so it should be
ok to change for 7.2.

-Rasmus

--001a113cf054ad567b0546a4b866--