Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97913
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.219 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbpoA2z8qpjWs_SidOoFyU0uEqJr2oAvyW3KCEu1zKr1Q@mail.gmail.com>
References: <CAGa2bXZ9EzWHDTBg_ZHGW4KdjiFK4tpE7aMCVTZD5n+UZ2vEWA@mail.gmail.com>
 <CANUQDCicMppoLU9k6gGj47Xk2PLOxdvA=Nb-y_CsXmXKCA_How@mail.gmail.com> <CAGa2bXbpoA2z8qpjWs_SidOoFyU0uEqJr2oAvyW3KCEu1zKr1Q@mail.gmail.com>
Date: Sat, 21 Jan 2017 15:45:21 +0100
Message-ID: <CANUQDCh5dC2-wNvOEkGd-cCNbhbb8nYuVLBTYZmupg2-2Qa0dg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Leigh <leight@gmail.com>
Content-Type: multipart/alternative; boundary=001a113771bae86df105469bd0f0
Subject: Re: [PHP-DEV] Use decent entropy for uniqid($prefix, TRUE)
From: me@kelunik.com (Niklas Keller)

--001a113771bae86df105469bd0f0
Content-Type: text/plain; charset=UTF-8

>
> I really don't see any pros for caring about failing CSPRNG and fallback
> to weak behavior.
>
> 1) BC is extremely unlikely. Basically, no BC on healthy hardware/OS.
> 2) Then things failed, programs should fail properly. i.e. Shouldn't
> fallback to weaker/problematic code.
>

Failing closed on a missing CSPRNG isn't really important for uniqid().
There's no guarantee that uniqid() produces ungessable output. It tries to
guarantee uniqueness and fails at the single one job it has for distributed
systems. I still think it's better to just leave it as is and deprecate it,
maybe while moving a UUID ext to core.

Regards, Niklas


> Broken CSPRNG is like BUS error, i.e. hardware error, why should we care
> so much about it?
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
>

--001a113771bae86df105469bd0f0--