Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:97862 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54449 invoked from network); 19 Jan 2017 01:11:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jan 2017 01:11:25 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:41828] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2D/DB-00729-B3210885 for ; Wed, 18 Jan 2017 20:11:24 -0500 Received: (qmail 108891 invoked by uid 89); 19 Jan 2017 01:11:20 -0000 Received: from unknown (HELO mail-wm0-f48.google.com) (yohgaki@ohgaki.net@74.125.82.48) by 0 with ESMTPA; 19 Jan 2017 01:11:20 -0000 Received: by mail-wm0-f48.google.com with SMTP id c206so53509518wme.0 for ; Wed, 18 Jan 2017 17:11:19 -0800 (PST) X-Gm-Message-State: AIkVDXKB5pzCGLUjFv9lj4aqfldgZhJV687kOWItZboSASn7b1liKwXhGnfdM2epK0DzWX8P274USMtgVW+DLQ== X-Received: by 10.28.230.194 with SMTP id e63mr5026213wmi.25.1484788272871; Wed, 18 Jan 2017 17:11:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.195.12.8 with HTTP; Wed, 18 Jan 2017 17:10:32 -0800 (PST) In-Reply-To: <8cfe7a3ea5a05fc3e5347e9af848ada0@gmail.com> References: <71c26cd6df6f59e76dafd31647852c2e@koti.fimnet.fi> <142a3537a99809cf23d78e0eaadc3aef@gmail.com> <7a359bb08b0ad8b046534c15492cec91@gmail.com> <8cfe7a3ea5a05fc3e5347e9af848ada0@gmail.com> Date: Thu, 19 Jan 2017 10:10:32 +0900 X-Gmail-Original-Message-ID: Message-ID: To: =?UTF-8?Q?Lauri_Kentt=C3=A4?= Cc: Nikita Popov , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a1147c8249245cd0546683575 Subject: Re: [PHP-DEV] Re: Improving mt_rand() seed From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a1147c8249245cd0546683575 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Lauri, On Thu, Jan 19, 2017 at 1:06 AM, Lauri Kentt=C3=A4 wrote: > On 2017-01-18 08:04, Yasuo Ohgaki wrote: > >> Lauri, >> You wrote the patch. Could you make Pull Request to github's php-src >> repo?If you prefer not to, I'll make the PR. >> >> I think your patch should be applied from PHP-7.0 branch. >> > > I've revised my patch (added GENERATE_SEED() fallback), see [1]. I can > send that against master if the approach is accepted here. If you want it > in PHP-7.0 or PHP-7.1, please merge it yourself, thank you. > > [1] https://github.com/Metabolix/php-src/tree/mt_srand_auto-pr Thank you. I have to be able to modify patch, so I'll fetch your change to my repo and make PR. BTW, I don't think we have to care for failing CSPRNG. If it failed, application should fail properly, i.e. should terminate process/code. PHP apps are not OS nor DBMS, they have freedom to terminate/exit when fata= l event happened. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a1147c8249245cd0546683575--