Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97783
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.218 cause and error)
MIME-Version: 1.0
In-Reply-To: <DB5PR0101MB17369EA346E27CFB74CBA862917D0@DB5PR0101MB1736.eurprd01.prod.exchangelabs.com>
References: <DB5PR0101MB1736F89440F718E955C7A89491660@DB5PR0101MB1736.eurprd01.prod.exchangelabs.com>
 <CAEKnhAHo4=HhfjnNDJu7M=KHipF9sC4ZZBcUCDjgk7nkUNT+eA@mail.gmail.com> <DB5PR0101MB17369EA346E27CFB74CBA862917D0@DB5PR0101MB1736.eurprd01.prod.exchangelabs.com>
Date: Mon, 16 Jan 2017 11:11:21 +0100
Message-ID: <CANUQDChbK_ivWSv2N_k9En+zbEcCge4M1zOUz2LqYwpgHCq_3g@mail.gmail.com>
To: Jani Ollikainen <jani.ollikainen@valve.fi>
Cc: Jakub Zelenka <bukka@php.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c0c98c8c6b1c605463367e9
Subject: Re: [PHP-DEV] Exposing jsonSerialize's depth
From: me@kelunik.com (Niklas Keller)

--94eb2c0c98c8c6b1c605463367e9
Content-Type: text/plain; charset=UTF-8

2017-01-16 9:19 GMT+01:00 Jani Ollikainen <jani.ollikainen@valve.fi>:

> Hi,
>
> > I don't really like this. The reason is that you don't actually modify
> JsonSerializable interface for the obvious BC break that it would cause it.
> It means that the > function just gets this parameter and it kind of raises
> a question how we should document it? The solution would be to extend
> JsonSerializable with some
> > new interface. However I don't think it's worth it for such thing. Maybe
> you should consider to pre-process your data before passing it to
> json_encode...
>
> What BC break are you talking about? There is no need for using the
> parameter in old codes. Even if we pass that depth to jsonSerialize doing
> something like:
> "public function jsonSerialize() {...}" will still work without any
> problems.
>

That BC break: https://3v4l.org/L1u7q

Regards, Niklas


> And how would you document it it? Like any other.. if there now is:
> http://php.net/manual/en/jsonserializable.jsonserialize.php
> abstract public mixed JsonSerializable::jsonSerialize ( void )
> This function has no parameters.
> Then it would just be:
> abstract public mixed JsonSerializable::jsonSerialize ( [integer $depth] )
> Parameters:
> depth
>   Depth of the current json_encode -call.
>
> New interface would also be good, but as you said it, it doesn't seem to
> be worth the trouble.
>
> Well, and what do you think how much does going pre-processing slow the
> code versus without need for pre-processing? That really doesn't sound
> option to me.
>
>

--94eb2c0c98c8c6b1c605463367e9--