Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97731
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.174 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
In-Reply-To: <CAL0xaBGP3a-MwuUaKtPjoWNuAGet0MZXH58e2onFSTfFhru9Lg@mail.gmail.com>
Date: Thu, 12 Jan 2017 14:52:23 -0600
Cc: PHP Internals List <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <254761B4-6B6B-4306-8CEE-286E133E3A06@gmail.com>
References: <D25FDAC5-A72F-4391-8414-8966124173ED@gmail.com>
 <CAL=_i_mFfPNpPZ0z48LdoKwNt4DLRpBpZbVUoCyz8Bi2PA82zg@mail.gmail.com>
 <0D275F6F-85D3-4E9D-AF89-03C91A23D5BD@gmail.com>
 <CAL=_i_kT6Dnty5pJFfoJy5aaffsvz_WfqdhTqJf76tatZdi9dg@mail.gmail.com>
 <BD978BDF-2D11-47EB-A700-C9BE312A1699@gmail.com>
 <CANaX5ne=RzeifBghLQxpZLb_wmbSppJFf=EEUX_D6Mi-QL3ZiA@mail.gmail.com>
 <CAL0xaBGP3a-MwuUaKtPjoWNuAGet0MZXH58e2onFSTfFhru9Lg@mail.gmail.com>
To: Arvids Godjuks <arvids.godjuks@gmail.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] ServerRequest and ServerResponse
 objects
From: pmjones88@gmail.com (Paul Jones)

Hi Arvids,

> On Jan 10, 2017, at 17:22, Arvids Godjuks <arvids.godjuks@gmail.com> =
wrote:
>=20
> I would also add the support, bug and feature issues that will =
definitely crop up with such an interface. If there is a major bug, flaw =
or security issue, getting it fixed is going to be a problem, because as =
we know, the adoption of PHP is nowhere near instantaneous and it can be =
years before you get the actual fix into the servers your =
project/projects are running on, and you can't do anything about this.

(/me nods) That particular problem is not specific to this RFC, though.  =
It's true for anything that gets into PHP.


> There are also questions - a 1GB upload comes in, will interface =
implement streams or some other way of handling that? Or there is a =
200MB gallery upload of images, with how most hosts set up their memory =
limits, I would imagine this would just run out of memory. And all that =
stuff.

Interesting -- what happens *now* without the ServerRequest RFC?  If a =
1GB upload comes in (or a 200MB gallery upload of images), then it gets =
dealt with under the RFC in exactly the same with PHP deals with it =
right now. That is: probably by attempting to store the uploads on disk, =
then exposing the file information via $_FILES.


> It's a way bigger job than I think the proposing person thinks, and it =
needs major support from the project maintainers, because I'm 146% sure =
one person will not be able to do it all and maintain it for next 10 =
years before it becomes integral part of the core...

It might well be a way bigger job than John & I think. However, I do =
have to point out that the vast majority of the functionality is pretty =
straightforward, and not terribly complex.  It's certainly not at the =
PDO, XML, Filter, etc. level of intricacy.


> This is something that needs to be tested and runned as a module for =
quite some time before it is stable enough to be in the core anyway - =
just see what happened to PDO  - as far as I know, no one really wants =
to touch it, it's a mess.

I can't speak to PDO, but I can say that APIs very similar to the one =
proposed in the RFC have been around for a long time, implemented by =
many different developers in many different systems. This RFC represents =
a summation and condensation of those behaviors.


--=20
Paul M. Jones
pmjones88@gmail.com
http://paul-m-jones.com

Modernizing Legacy Applications in PHP
https://leanpub.com/mlaphp

Solving the N+1 Problem in PHP
https://leanpub.com/sn1php