Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:97723 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85347 invoked from network); 12 Jan 2017 10:27:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Jan 2017 10:27:37 -0000 Authentication-Results: pb1.pair.com smtp.mail=sachavav@tut.by; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=sachavav@tut.by; sender-id=pass Received-SPF: pass (pb1.pair.com: domain tut.by designates 37.9.109.243 as permitted sender) X-PHP-List-Original-Sender: sachavav@tut.by X-Host-Fingerprint: 37.9.109.243 forward2o.cmail.yandex.net Received: from [37.9.109.243] ([37.9.109.243:57787] helo=forward2o.cmail.yandex.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 95/34-50165-51A57785 for ; Thu, 12 Jan 2017 05:27:35 -0500 Received: from mxback11h.mail.yandex.net (mxback11h.mail.yandex.net [IPv6:2a02:6b8:0:f05::203]) by forward2o.cmail.yandex.net (Yandex) with ESMTP id 2D1DB20C96; Thu, 12 Jan 2017 13:27:29 +0300 (MSK) Received: from web20h.yandex.ru (web20h.yandex.ru [84.201.186.49]) by mxback11h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id pBw8Yo6Rn4-RSV0Etbc; Thu, 12 Jan 2017 13:27:28 +0300 Received: by web20h.yandex.ru with HTTP; Thu, 12 Jan 2017 13:27:28 +0300 To: Kalle Sommer Nielsen Cc: Internals In-Reply-To: References: <4083361484210288@web9o.yandex.ru> MIME-Version: 1.0 Message-ID: <2917211484216848@web20h.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 12 Jan 2017 13:27:28 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Subject: Re: [PHP-DEV] Small mistake on wiki From: sachavav@tut.by 12.01.2017, 11:59, "Kalle Sommer Nielsen" : > Hi > > 2017-01-12 9:38 GMT+01:00 : >>  Hi, >> >>  The page https://wiki.php.net/phpng-upgrading#call_frame_changes_zend_execute_data >>  says: >> >>>  zend_execute_data.num_args - number of arguments passed to the function (this is a new field) >> >>  However, there's no such field in zend_execute_data structure: >>  https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L430 >>  it's in zend_function: https://github.com/php/php-src/blob/PHP-7.0.15/Zend/zend_compile.h#L414 >> >>  Probably this line should be removed from the wiki page. > > True, but PHP 5 is still widely available and 5.6 is still supported. > Some companies support their extensions for PHP even longer than we > support that specific branch, so leaving such information, despite we > have only a tiny bit internals docs laying around may not be such a > bad idea. This wiki page is specifically for PHP 7 migration, it has nothing to do with PHP5