Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97717
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 104.47.37.112 as permitted sender)
To: Bob Weinand <bobwei9@hotmail.com>
CC: Derick Rethans <derick@php.net>, PHP internals list
	<internals@lists.php.net>, Joe Watkins <pthreads@pthreads.org>, Zeev Suraski
	<zeev@zend.com>, "Anatol Belski (ab@php.net)" <ab@php.net>, Nikita Popov
	<nikic@php.net>, Xinchen Hui <xinchen.hui@roguewave.com>
Thread-Topic: [PHP-DEV] Change in type-hint representation
Thread-Index: AQHSbAGJJH94e0ZZMkmDI5OUmOzW+6Ezav4AgAAN+yiAABvagIAA7QKY
Date: Thu, 12 Jan 2017 08:23:36 +0000
Message-ID: <MWHPR02MB2477CB89268F97D72D837F68BF790@MWHPR02MB2477.namprd02.prod.outlook.com>
References: <MWHPR02MB24771DF68193D22668A6EE63BF660@MWHPR02MB2477.namprd02.prod.outlook.com>
 <alpine.DEB.2.20.1701111540260.4733@whisky.home.derickrethans.nl>
 <MWHPR02MB24778BAD673E0A28C300EAACBF660@MWHPR02MB2477.namprd02.prod.outlook.com>,<BLU436-SMTP20E74FF32582B72A1B0F69E2660@phx.gbl>
In-Reply-To: <BLU436-SMTP20E74FF32582B72A1B0F69E2660@phx.gbl>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [25.173.117.4]
x-microsoft-exchange-diagnostics: 1;MWHPR02MB2509;7:cOrxIYgzUpgu+Dgq4aX6dlMspzi3GXJnUd5l5/stRDcTmSeGUz9JD1GUMsSXykCKrIHeNjRobOU5SRw0I0cRyR3VumABexMwj1J+vzohJr4JccFGRyxcFKnmjpDs8se2loFXvp9D/GhkMvuhqgVfMUR1Jf2HLb0h70wx5xA56o+wVmfLDzdordEhq9653pfxgFRfm9VvkZLm6xgfUYHhbv3bm/VnEQT5yfegluUMHSHBSv5nC4jlGVydBf/+Vw+XxocMRcIteUgAveBpnacW+xgrrMsNJk5wR4FnVUkJLF/IMtNhZriU0BchCjsg2OFvZZlh9gbazAvHe8lV0WNWzxjHkviLyT+tQbzSfqckiD+rMIw+DwTgPNccbC0OGXn0gmJ8UU0+AfAJY0vHv7jENB0hB2HBcroht41F/2iWpNq7wgEWkQNfDQsXw6PFQVxKmX7T6ITeHKpKEbP4eEMV3g==
x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10019020)(7916002)(39450400003)(377454003)(199003)(189002)(3846002)(76176999)(102836003)(105586002)(6116002)(106356001)(66066001)(3280700002)(74316002)(50986999)(54356999)(106116001)(68736007)(2906002)(3660700001)(4001430100002)(33656002)(4326007)(7736002)(101416001)(7906003)(97736004)(107886002)(110136003)(93886004)(8936002)(189998001)(9686003)(6506006)(229853002)(54896002)(6306002)(6436002)(2950100002)(6916009)(81156014)(122556002)(38730400001)(606005)(8676002)(81166006)(77096006)(39060400001)(236005)(575784001)(86362001)(7696004)(92566002)(2900100001)(54906002)(99286003)(55016002)(5660300001)(25786008);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR02MB2509;H:MWHPR02MB2477.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
x-ms-office365-filtering-correlation-id: cd0bbb59-48f6-4954-6c9b-08d43ac44e35
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR02MB2509;
x-microsoft-antispam-prvs: <MWHPR02MB25098D83348591CA3C3F0D7EBF790@MWHPR02MB2509.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(158342451672863)(166708455590820)(194151415913766)(192278398808882);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(6072148);SRVR:MWHPR02MB2509;BCL:0;PCL:0;RULEID:;SRVR:MWHPR02MB2509;
x-forefront-prvs: 018577E36E
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_MWHPR02MB2477CB89268F97D72D837F68BF790MWHPR02MB2477namp_"
MIME-Version: 1.0
X-OriginatorOrg: zend.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2017 08:23:36.3575
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2509
Subject: Re: [PHP-DEV] Change in type-hint representation
From: dmitry@zend.com (Dmitry Stogov)

--_000_MWHPR02MB2477CB89268F97D72D837F68BF790MWHPR02MB2477namp_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

Hi Bob,


I don't exactly understand, what do you like.

Can you explain, or may be make it on top of this patch? (I think I'll comm=
it it on Friday)


Thanks. Dmitry.

________________________________
From: Bob Weinand <bobwei9@hotmail.com>
Sent: Wednesday, January 11, 2017 9:13:33 PM
To: Dmitry Stogov
Cc: Derick Rethans; PHP internals list; Joe Watkins; Zeev Suraski; Anatol B=
elski (ab@php.net); Nikita Popov; Xinchen Hui
Subject: Re: [PHP-DEV] Change in type-hint representation


> Am 11.01.2017 um 17:37 schrieb Dmitry Stogov <dmitry@zend.com>:
>
> The patch was updated according to feedback: added comments, better names=
 and encapsulation, less magic, better code reuse, keep a free bit in zend_=
type for future extension.
> <https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1>
>
>
> <https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1>
>
> https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1
>
>
> Thanks. Dmitry.

Looks good so far=85

Thought I've asked you before on IRC to somehow extract validation so that =
we don't have to duplicate it everywhere.

Validate (and cast if necessary) given a zval, strict mode and the represen=
tation type (class present as ce? as string?)

Also, perhaps a string representation of the type (reusable in reflection a=
nd in error messages)

Thanks,
Bob

--_000_MWHPR02MB2477CB89268F97D72D837F68BF790MWHPR02MB2477namp_--