Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97715
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 104.47.33.137 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>
CC: Dmitry Stogov <dmitry@zend.com>, Xinchen Hui <xinchen.hui@roguewave.com>,
	Zeev Suraski <zeev@zend.com>, Nikita Popov <nikic@php.net>, Joe Watkins
	<pthreads@pthreads.org>, "Anatol Belski (ab@php.net)" <ab@php.net>, "Bob
 Weinand" <bobwei9@hotmail.com>, PHP internals list <internals@lists.php.net>
Thread-Topic: Change in type-hint representation
Thread-Index: AQHSbKo5JH94e0ZZMkmDI5OUmOzW+w==
Date: Thu, 12 Jan 2017 08:07:02 +0000
Message-ID: <MWHPR02MB247770A47BC24225D317D159BF790@MWHPR02MB2477.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_MWHPR02MB247770A47BC24225D317D159BF790MWHPR02MB2477namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2017 08:07:02.1689
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2480
Subject: Re: Change in type-hint representation
From: dmitry@zend.com (Dmitry Stogov)

--_000_MWHPR02MB247770A47BC24225D317D159BF790MWHPR02MB2477namp_
Content-Type: text/plain; charset="koi8-r"
Content-Transfer-Encoding: quoted-printable



On Jan 11, 2017 11:46 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
On Wed, Jan 11, 2017 at 1:07 PM, Dmitry Stogov <dmitry@zend.com<mailto:dmit=
ry@zend.com>> wrote:

Hi,


I propose to introduce a unified type representation (zend_type).

Now it's going to be used for typing of arguments and return values.

Later we should use it for properties and other things.


https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1


The main changes are in zend_types.h and zend_compile.h, the rest is just a=
n adoption for new type representation.

I don't think we need RFC, because this is just an internal change that doe=
sn't change behavior.


I got the idea working on typed properties together with Bob and Joe.

https://github.com/php/php-src/compare/master...bwoebi:typed_ref_properties

I think it would be better to introduce zend_type and then continue work on=
 typed properties.


Any comments?


Thanks. Dmitry.

I like this. Two questions:

1. Can you please clarify what ZEND_TYPE_ENCODE_CLASS_CONST_* is for? Why d=
oes this not use the usual encoding for allow_null? Does the compiler not a=
llow casts in initializers or something?

They are used for constant initializers. Compiler doesn't allow operations =
with addresses of constant strings, because they are assigned only by ld.


2. Is the use of zend_strings in arginfo of internal functions zts safe? I.=
e. does the function registration happen per-thread or do we reuse register=
ed functions across threads? If that's the case we might run into issues wi=
th non-atomic RCs.

Good point. I'll check this.

Thanks. Dmitry.


Nikita


--_000_MWHPR02MB247770A47BC24225D317D159BF790MWHPR02MB2477namp_--