Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97701
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <MWHPR02MB24771DF68193D22668A6EE63BF660@MWHPR02MB2477.namprd02.prod.outlook.com>
References: <MWHPR02MB24771DF68193D22668A6EE63BF660@MWHPR02MB2477.namprd02.prod.outlook.com>
Date: Wed, 11 Jan 2017 21:46:02 +0100
Message-ID: <CAF+90c8M6bhfeBNx4sG4L_DMG_RoQFbu47qsWtmN9-FkYAqu0g@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals list <internals@lists.php.net>, Bob Weinand <bobwei9@hotmail.com>, 
	Joe Watkins <pthreads@pthreads.org>, Zeev Suraski <zeev@zend.com>, 
	"Anatol Belski (ab@php.net)" <ab@php.net>, Nikita Popov <nikic@php.net>, Xinchen Hui <xinchen.hui@roguewave.com>
Content-Type: multipart/alternative; boundary=001a114d76f46bd9e50545d7b0e6
Subject: Re: Change in type-hint representation
From: nikita.ppv@gmail.com (Nikita Popov)

--001a114d76f46bd9e50545d7b0e6
Content-Type: text/plain; charset=UTF-8

On Wed, Jan 11, 2017 at 1:07 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi,
>
>
> I propose to introduce a unified type representation (zend_type).
>
> Now it's going to be used for typing of arguments and return values.
>
> Later we should use it for properties and other things.
>
>
> https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1
>
>
> The main changes are in zend_types.h and zend_compile.h, the rest is just
> an adoption for new type representation.
>
> I don't think we need RFC, because this is just an internal change that
> doesn't change behavior.
>
>
> I got the idea working on typed properties together with Bob and Joe.
>
> https://github.com/php/php-src/compare/master...bwoebi:
> typed_ref_properties
>
> I think it would be better to introduce zend_type and then continue work
> on typed properties.
>
>
> Any comments?
>
>
> Thanks. Dmitry.
>
I like this. Two questions:

1. Can you please clarify what ZEND_TYPE_ENCODE_CLASS_CONST_* is for? Why
does this not use the usual encoding for allow_null? Does the compiler not
allow casts in initializers or something?

2. Is the use of zend_strings in arginfo of internal functions zts safe?
I.e. does the function registration happen per-thread or do we reuse
registered functions across threads? If that's the case we might run into
issues with non-atomic RCs.

Nikita

--001a114d76f46bd9e50545d7b0e6--