Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97693
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.66 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <MWHPR02MB24778BAD673E0A28C300EAACBF660@MWHPR02MB2477.namprd02.prod.outlook.com>
References: <MWHPR02MB24771DF68193D22668A6EE63BF660@MWHPR02MB2477.namprd02.prod.outlook.com>
 <alpine.DEB.2.20.1701111540260.4733@whisky.home.derickrethans.nl> <MWHPR02MB24778BAD673E0A28C300EAACBF660@MWHPR02MB2477.namprd02.prod.outlook.com>
Date: Wed, 11 Jan 2017 10:24:53 -0700
Message-ID: <CAFMT4NqrBPppSLOL-dZ-xdU1kMp8PzTRw5s5WsVZPnnydfM2fA@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Derick Rethans <derick@php.net>, PHP internals list <internals@lists.php.net>, 
	Bob Weinand <bobwei9@hotmail.com>, Joe Watkins <pthreads@pthreads.org>, 
	Zeev Suraski <zeev@zend.com>, "Anatol Belski (ab@php.net)" <ab@php.net>, Nikita Popov <nikic@php.net>, 
	Xinchen Hui <xinchen.hui@roguewave.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Change in type-hint representation
From: levim@php.net (Levi Morrison)

On Wed, Jan 11, 2017 at 9:37 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> The patch was updated according to feedback: added comments, better names and encapsulation, less magic, better code reuse, keep a free bit in zend_type for future extension.
> <https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1>
>
>
> <https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1>
>
> https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1
>
>
> Thanks. Dmitry.
>
>
>
> ________________________________
> From: Derick Rethans <derick@php.net>
> Sent: Wednesday, January 11, 2017 6:43:50 PM
> To: Dmitry Stogov
> Cc: PHP internals list; Bob Weinand; Joe Watkins; Zeev Suraski; Anatol Belski (ab@php.net); Nikita Popov; Xinchen Hui
> Subject: Re: [PHP-DEV] Change in type-hint representation
>
> On Wed, 11 Jan 2017, Dmitry Stogov wrote:
>
>> Hi,
>>
>>
>> I propose to introduce a unified type representation (zend_type).
>>
>> Now it's going to be used for typing of arguments and return values.
>>
>> Later we should use it for properties and other things.
>>
>>
>> https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1
>>
>>
>> The main changes are in zend_types.h and zend_compile.h, the rest is just an adoption for new type representation.
>>
>> I don't think we need RFC, because this is just an internal change that doesn't change behavior.
>>
>>
>> I got the idea working on typed properties together with Bob and Joe.
>>
>> https://github.com/php/php-src/compare/master...bwoebi:typed_ref_properties
>>
>> I think it would be better to introduce zend_type and then continue work on typed properties.
>>
>>
>> Any comments?
>
> 208 +                           if (new_arg_info[i].type > 0x3ff) {
>
> I wouldn't use a magical constant there, but do a define of what 0x3ff
> actually is.
>
> 209 +                                   /* this is a calss name */
>
> That's spelled "class" (not "calss").
>
> cheers,
> Derick

As part of this effort can we refactor the IS_LONG, IS_ARRAY,
IS_OBJECT, etc macros to use an enum? Maybe `zend_type_code` if you
like the `code` name for it? Also we already use "kind" in the AST;
should it be `ZEND_TYPE_KIND` and `zend_type_kind` instead?

Overall I think this cleanup is needed. Thanks, Dmitry.