Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97692
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 104.47.34.130 as permitted sender)
To: Derick Rethans <derick@php.net>
CC: PHP internals list <internals@lists.php.net>, Bob Weinand
	<bobwei9@hotmail.com>, Joe Watkins <pthreads@pthreads.org>, Zeev Suraski
	<zeev@zend.com>, "Anatol Belski (ab@php.net)" <ab@php.net>, Nikita Popov
	<nikic@php.net>, Xinchen Hui <xinchen.hui@roguewave.com>
Thread-Topic: [PHP-DEV] Change in type-hint representation
Thread-Index: AQHSbAGJJH94e0ZZMkmDI5OUmOzW+6Ezav4AgAAN+yg=
Date: Wed, 11 Jan 2017 16:37:57 +0000
Message-ID: <MWHPR02MB24778BAD673E0A28C300EAACBF660@MWHPR02MB2477.namprd02.prod.outlook.com>
References: <MWHPR02MB24771DF68193D22668A6EE63BF660@MWHPR02MB2477.namprd02.prod.outlook.com>,<alpine.DEB.2.20.1701111540260.4733@whisky.home.derickrethans.nl>
In-Reply-To: <alpine.DEB.2.20.1701111540260.4733@whisky.home.derickrethans.nl>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_MWHPR02MB24778BAD673E0A28C300EAACBF660MWHPR02MB2477namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2017 16:37:57.7150
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2511
Subject: Re: [PHP-DEV] Change in type-hint representation
From: dmitry@zend.com (Dmitry Stogov)

--_000_MWHPR02MB24778BAD673E0A28C300EAACBF660MWHPR02MB2477namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

The patch was updated according to feedback: added comments, better names a=
nd encapsulation, less magic, better code reuse, keep a free bit in zend_ty=
pe for future extension.
<https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1>


<https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1>

https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1


Thanks. Dmitry.



________________________________
From: Derick Rethans <derick@php.net>
Sent: Wednesday, January 11, 2017 6:43:50 PM
To: Dmitry Stogov
Cc: PHP internals list; Bob Weinand; Joe Watkins; Zeev Suraski; Anatol Bels=
ki (ab@php.net); Nikita Popov; Xinchen Hui
Subject: Re: [PHP-DEV] Change in type-hint representation

On Wed, 11 Jan 2017, Dmitry Stogov wrote:

> Hi,
>
>
> I propose to introduce a unified type representation (zend_type).
>
> Now it's going to be used for typing of arguments and return values.
>
> Later we should use it for properties and other things.
>
>
> https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1
>
>
> The main changes are in zend_types.h and zend_compile.h, the rest is just=
 an adoption for new type representation.
>
> I don't think we need RFC, because this is just an internal change that d=
oesn't change behavior.
>
>
> I got the idea working on typed properties together with Bob and Joe.
>
> https://github.com/php/php-src/compare/master...bwoebi:typed_ref_properti=
es
>
> I think it would be better to introduce zend_type and then continue work =
on typed properties.
>
>
> Any comments?

208 +                           if (new_arg_info[i].type > 0x3ff) {

I wouldn't use a magical constant there, but do a define of what 0x3ff
actually is.

209 +                                   /* this is a calss name */

That's spelled "class" (not "calss").

cheers,
Derick

--_000_MWHPR02MB24778BAD673E0A28C300EAACBF660MWHPR02MB2477namp_--