Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:97690 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94857 invoked from network); 11 Jan 2017 15:43:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Jan 2017 15:43:56 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Received: from [82.113.146.227] ([82.113.146.227:45548] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6A/71-55699-BB256785 for ; Wed, 11 Jan 2017 10:43:56 -0500 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id CB2BA10C026; Wed, 11 Jan 2017 15:43:51 +0000 (GMT) Date: Wed, 11 Jan 2017 15:43:50 +0000 (GMT) X-X-Sender: derick@whisky.home.derickrethans.nl To: Dmitry Stogov cc: PHP internals list , Bob Weinand , Joe Watkins , Zeev Suraski , "Anatol Belski (ab@php.net)" , Nikita Popov , Xinchen Hui In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [PHP-DEV] Change in type-hint representation From: derick@php.net (Derick Rethans) On Wed, 11 Jan 2017, Dmitry Stogov wrote: > Hi, > > > I propose to introduce a unified type representation (zend_type). > > Now it's going to be used for typing of arguments and return values. > > Later we should use it for properties and other things. > > > https://gist.github.com/dstogov/1b25079856afccf0d69f77d499cb0ab1 > > > The main changes are in zend_types.h and zend_compile.h, the rest is just an adoption for new type representation. > > I don't think we need RFC, because this is just an internal change that doesn't change behavior. > > > I got the idea working on typed properties together with Bob and Joe. > > https://github.com/php/php-src/compare/master...bwoebi:typed_ref_properties > > I think it would be better to introduce zend_type and then continue work on typed properties. > > > Any comments? 208 + if (new_arg_info[i].type > 0x3ff) { I wouldn't use a magical constant there, but do a define of what 0x3ff actually is. 209 + /* this is a calss name */ That's spelled "class" (not "calss"). cheers, Derick