Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97666
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.68 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <000501d26b51$d1119880$7334c980$@marcodor.com>
References: <CAPv8svXpjJGBr6YQaz97aC2KLADxrJSrTtBuTdk2fCKXv6xL3g@mail.gmail.com>
 <CADxrgCPMd8fDQfJ+Vb48FhrRaNMDdvMpcayX5iqg3+_g2zBcpA@mail.gmail.com>
 <02dc01d26850$eb4e3810$c1eaa830$@belski.net> <001001d26852$6bf9ddb0$43ed9910$@marcodor.com>
 <CAPv8svVEunWkN+M1dLq+ECS8tHFMOe8HDgW9sX=NSaXqrgdj2Q@mail.gmail.com> <000501d26b51$d1119880$7334c980$@marcodor.com>
Date: Tue, 10 Jan 2017 13:04:36 -0500
Message-ID: <CADxrgCMRY=U6eEx8ESGOfqxUU7-ZJVRE2TNQmLGP7eYOLKjYpg@mail.gmail.com>
To: Dorin Marcoci <dorin.marcoci@marcodor.com>
Cc: marius adrian popa <mapopa@gmail.com>, Anatol Belski <anatol.php@belski.net>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c05c3002f75be0545c1519f
Subject: Re: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping for
 integers (smallint, integer, bigint) in PDO_Firebird driver
From: adambaratz@php.net (Adam Baratz)

--94eb2c05c3002f75be0545c1519f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

>
> Unfortunately with current PDO state this is not possible to be done in a
> nice way.
> Now PDO have defined just these field types: PDO::PARAM_BOOL,
> PDO::PARAM_INT, PDO::PARAM_STR, PDO::PARAM_LOB, PDO::PARAM_NULL.
> Last one is =E2=80=9Cwrong=E2=80=9D and should be removed. NULL is a stat=
e, not a type or
> a value. See #73852 bug.
> So PDO should be extended with at least PDO::PARAM_FLOAT to add
> floats/double mapping. It needs an RFC to be extended.
> In plans is to add yet for booleans, Firebird3 bool data type.


Column data can be treated differently from parameter types. I went through
this exercise with pdo_dblib:
https://github.com/php/php-src/blob/master/ext/pdo_dblib/dblib_stmt.c#L254

It's a little clunky to deal with the pointers correctly, but if Firebird
reports a type, you might as well honor it.

I didn't realize until you posted this change that PDO core would cast to
ints in some cases. It made me wonder if that code should deal with other
types or whether all type handling should be pushed into the drivers.
Definitely a separate topic, though...

Regarding additional parameter types, it's on my todo to write up an RFC to
cover some ambiguous cases:

   - Binary data (see https://bugs.php.net/bug.php?id=3D47982)
   - Floating point numbers (see https://www.mail-archive.
   com/internals@lists.php.net/msg89591.html
   <https://www.mail-archive.com/internals@lists.php.net/msg89591.html>)
   - Unicode (touched on with
   https://www.mail-archive.com/internals@lists.php.net/msg88713.html)

My perspective is mainly as someone who works with pdo_dblib. Emulated
prepares make a greater degree of control more desirable in some cases. I
need to think through how such types would impact other drivers, and I've
unfortunately been short on time for the exercise.

Adam

--94eb2c05c3002f75be0545c1519f--