Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97663
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain marcodor.com designates 93.115.138.71 as permitted sender)
To: "'marius adrian popa'" <mapopa@gmail.com>
Cc: "'Anatol Belski'" <anatol.php@belski.net>,
	"'Adam Baratz'" <adambaratz@php.net>,
	"'PHP Developers Mailing List'" <internals@lists.php.net>
References: <CAPv8svXpjJGBr6YQaz97aC2KLADxrJSrTtBuTdk2fCKXv6xL3g@mail.gmail.com> <CADxrgCPMd8fDQfJ+Vb48FhrRaNMDdvMpcayX5iqg3+_g2zBcpA@mail.gmail.com> <02dc01d26850$eb4e3810$c1eaa830$@belski.net> <001001d26852$6bf9ddb0$43ed9910$@marcodor.com> <CAPv8svVEunWkN+M1dLq+ECS8tHFMOe8HDgW9sX=NSaXqrgdj2Q@mail.gmail.com>
In-Reply-To: <CAPv8svVEunWkN+M1dLq+ECS8tHFMOe8HDgW9sX=NSaXqrgdj2Q@mail.gmail.com>
Date: Tue, 10 Jan 2017 16:57:09 +0200
Organization: Marcodor
Message-ID: <000501d26b51$d1119880$7334c980$@marcodor.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKOV1z6yLYA/XiBhzL6jPyAglZyvQHDfiIqAeTS95oDE4SanQKJ/JJWn2/EErA=
Content-Language: ro
Subject: RE: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping for integers (smallint, integer, bigint) in PDO_Firebird driver
From: dorin.marcoci@marcodor.com ("Dorin Marcoci")

Hello Marius,

Unfortunately with current PDO state this is not possible to be done in =
a nice way.
Now PDO have defined just these field types: PDO::PARAM_BOOL, =
PDO::PARAM_INT, PDO::PARAM_STR, PDO::PARAM_LOB, PDO::PARAM_NULL.
Last one is =E2=80=9Cwrong=E2=80=9D and should be removed. NULL is a =
state, not a type or a value. See #73852 bug.
So PDO should be extended with at least PDO::PARAM_FLOAT to add =
floats/double mapping. It needs an RFC to be extended.
In plans is to add yet for booleans, Firebird3 bool data type.

-
  Dorin Marcoci



From: marius adrian popa [mailto:mapopa@gmail.com]=20
Sent: Tuesday, January 10, 2017 3:33 PM
To: Dorin Marcoci <dorin.marcoci@marcodor.com>
Cc: Anatol Belski <anatol.php@belski.net>; Adam Baratz =
<adambaratz@php.net>; PHP Developers Mailing List =
<internals@lists.php.net>
Subject: Re: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping =
for integers (smallint, integer, bigint) in PDO_Firebird driver

Could you add also type mapping for float , double ...

On Fri, Jan 6, 2017 at 9:23 PM, Dorin Marcoci =
<mailto:dorin.marcoci@marcodor.com> wrote:
Yep, setting this flag, integers became strings, so all OK, we have a =
toggle.
A nice weekend to all! :)


-----Original Message-----
From: Anatol Belski [mailto:mailto:anatol.php@belski.net]
Sent: Friday, January 6, 2017 9:13 PM
To: 'Adam Baratz' <mailto:adambaratz@php.net>; 'marius adrian popa' =
<mailto:mapopa@gmail.com>
Cc: 'PHP Developers Mailing List' <mailto:internals@lists.php.net>; =
'Dorin Marcoci' <mailto:dorin.marcoci@marcodor.com>
Subject: RE: [PHP-DEV] Dorin Marcoci Added Firebrid native type mapping =
for integers (smallint, integer, bigint) in PDO_Firebird driver

Hi,

> -----Original Message-----
> From: Adam Baratz [mailto:mailto:adambaratz@php.net]
> Sent: Friday, January 6, 2017 7:59 PM
> To: marius adrian popa <mailto:mapopa@gmail.com>
> Cc: PHP Developers Mailing List <mailto:internals@lists.php.net>
> Subject: Re: [PHP-DEV] Dorin Marcoci Added Firebrid native type
> mapping for integers (smallint, integer, bigint) in PDO_Firebird
> driver
>
> >
> > <https://github.com/madorin/php-src/tree/fb_native>Firebrid
> > native type mapping for integers (smallint, integer, bigint) in
> > PDO_Firebird driver
>
>
> It looks like this is an "always on" feature. There's a PDO attribute,
> PDO::ATTR_STRINGIFY_FETCHES, that's intended to allow toggling. Since
> this is a functionality change, I'd suggest supporting it. It'll make
> it easier for users to migrate if they have any baked-in assumptions =
around getting strings back.
>
Good catch. Dorin, would you be up to implement this please?

Thanks

Anatol