Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97632
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbjpEBGj3=U_d2yg6qHhzW-1+zY_2AvBZQJSyep5kMUfw@mail.gmail.com>
References: <CAGa2bXbgPpO4CfHyHrDDhbXsysk7HDsc17nQoGtWNv4zdaq5kA@mail.gmail.com>
 <CAGa2bXZuKmGJu2bnnoqi1DjnyvBL=9VLM=jgffXFfoWf4SJk3Q@mail.gmail.com>
 <CAF+90c9fH4qUc8p4m5+8Q+P+gsKP8sOxGVw2sx5fSVvKHtf4Pg@mail.gmail.com> <CAGa2bXbjpEBGj3=U_d2yg6qHhzW-1+zY_2AvBZQJSyep5kMUfw@mail.gmail.com>
Date: Mon, 9 Jan 2017 10:49:44 -0600
Message-ID: <CALrkBjZwjyKEAiW9+DWR4jSB8dZNUDX+RRwAvdA2pqMKtCBWbw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c058ce8a33e9d0545ac272b
Subject: Re: [PHP-DEV] Re: Improving mail() 5th parameter handling
From: pencap@gmail.com (Mike Willbanks)

--94eb2c058ce8a33e9d0545ac272b
Content-Type: text/plain; charset=UTF-8

On Sun, Jan 8, 2017 at 4:56 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Nikita and all,
>
> On Mon, Jan 9, 2017 at 7:31 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> > Without this option, how do you specify the envelope sender? That seems
> to
> > be the primary use-case.
>
>
> Indeed, it seems it is.
> It could be set by mail.force_extra_parameters. I agree this isn't a great
> way to do, but the obstacle may help users to notice risks.
>
> Parameters must be validated still, but it will help in most cases and I
> don't mind writing patch for arrayed 'addtional_parameter'. In this case,
> I'll just fix this as normal bug fix and post proposed patch before commit.
> Any comments on this?
>


Removing the 5th parameter would be a serious mistake and limitation IMO.
Moving the additional_headers and additional_parameters to be an array of
parameters would resolve most of the main issues I see here but forcing an
INI setting here would be a mistake, huge BC break and overall not
something you could fix as a "bug fix" in this case in particular.


>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--94eb2c058ce8a33e9d0545ac272b--