Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97588
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain gmail.com does not designate 178.62.210.197 as permitted sender)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Sun, 08 Jan 2017 19:29:18 +0200
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: internals@lists.php.net
In-Reply-To: <CAGa2bXaZPBYTaXzNDnA32BCBoZ_FzFUnRNYKFY8b1TXAWSwMyg@mail.gmail.com>
References: <CAGa2bXZ9EzWHDTBg_ZHGW4KdjiFK4tpE7aMCVTZD5n+UZ2vEWA@mail.gmail.com>
 <7500b0c6a50baf49beac70ae01e8b50d@koti.fimnet.fi>
 <CAGa2bXaZPBYTaXzNDnA32BCBoZ_FzFUnRNYKFY8b1TXAWSwMyg@mail.gmail.com>
Message-ID: <f85149180bfa3920c4c4076a59904b50@gmail.com>
User-Agent: Roundcube Webmail/1.2.3
Subject: Re: [PHP-DEV] Use decent entropy for uniqid($prefix, TRUE)
From: lauri.kentta@gmail.com (=?UTF-8?Q?Lauri_Kentt=C3=A4?=)

On 2017-01-07 03:15, Yasuo Ohgaki wrote:
> +               php_random_int(1000000000, 9999999999, &rand, 1);
> 
> This should be
> 
> +               php_random_int(0, 9999999999, &rand, 1);

No, it shouldn't. That fixes none of the reported problems. You still 
have too many numbers (integer overflow) and still produce 0.abcdefgh 
instead of a.bcdefghi.

If you can't fix it, maybe you shouldn't be doing it in the first 
place...

-- 
Lauri Kenttä