Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:97551 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19613 invoked from network); 7 Jan 2017 01:27:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Jan 2017 01:27:04 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:48098] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B9/3E-23307-6E340785 for ; Fri, 06 Jan 2017 20:27:04 -0500 Received: (qmail 43783 invoked by uid 89); 7 Jan 2017 01:26:58 -0000 Received: from unknown (HELO mail-wm0-f41.google.com) (yohgaki@ohgaki.net@74.125.82.41) by 0 with ESMTPA; 7 Jan 2017 01:26:58 -0000 Received: by mail-wm0-f41.google.com with SMTP id c85so44333590wmi.1 for ; Fri, 06 Jan 2017 17:26:57 -0800 (PST) X-Gm-Message-State: AIkVDXKuz9lqk6qWYH8jb1PQs4WwoKdsZ1oFuMEoeJpdxxrW3IxOPmQmg2AUGhYYRns75cikVbfiFLvBR6tDig== X-Received: by 10.28.25.135 with SMTP id 129mr422559wmz.122.1483752411544; Fri, 06 Jan 2017 17:26:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.195.12.8 with HTTP; Fri, 6 Jan 2017 17:26:11 -0800 (PST) In-Reply-To: References: <87y3yupshj.fsf@lil.giraffy.jp> Date: Sat, 7 Jan 2017 10:26:11 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Kazuo Oishi Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a114d3d4a6cc535054577074f Subject: Re: [PHP-DEV] Use decent entropy for uniqid($prefix, TRUE) From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a114d3d4a6cc535054577074f Content-Type: text/plain; charset=UTF-8 Hi Kazuo, On Sat, Jan 7, 2017 at 9:54 AM, Yasuo Ohgaki wrote: > You misunderstand the mail. > PHPMailer and uniqid() fix is unrelated, but uniqid() is misused proposed > patch in obvious way. > > >> >> What's your intention? >> > > The point we should learn from the code is, it is clear that users > misunderstand how uniqid() works. You'll find number of such usages if you > search net. There is uniqid() improvement RFC https://wiki.php.net/rfc/uniqid The proposed patch for PHPmailer proves we should improve 'more_entropy' option and enable it by default. That's my point. Enabling 'more_entropy' option by default will be handled by RFC process, but we can simply improve randomness of 'more_entropy' w/o BC for now. This is what I proposed. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a114d3d4a6cc535054577074f--