Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97535
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAOv67gsoM-YzehWNg9ThB9g23eSHnnvsf6gLU8LrkkA3TtDAKA@mail.gmail.com>
References: <CAOv67guO_YydoeNuA6ph3fALuGvU49yAcOvAYrkEbifb4hHM2A@mail.gmail.com>
 <CADyq6sL7ezP06avAXi5YqQV5u_cGiZnhZ0GrD2TtbGYdqsQuRA@mail.gmail.com>
 <CADyq6s+bbxsM30uLPoLmCb7z2YFR-fZBG8UFU3Bb1ptMjngepw@mail.gmail.com>
 <CADyq6sKL8Y1_27gikedSeQz+CC8iUCCiNJx1D1Lfg=Sgrgt49Q@mail.gmail.com> <CAOv67gsoM-YzehWNg9ThB9g23eSHnnvsf6gLU8LrkkA3TtDAKA@mail.gmail.com>
Date: Fri, 6 Jan 2017 18:33:38 +0100
Message-ID: <CADyq6s+dFWcGeZOSv-qi1c9-tQSpW0ikCm4Amp2aHtH_iKg-GQ@mail.gmail.com>
To: Wes <netmo.php@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11443a361b86c50545706bd8
Subject: Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization
From: ocramius@gmail.com (Marco Pivetta)

--001a11443a361b86c50545706bd8
Content-Type: text/plain; charset=UTF-8

On 6 Jan 2017 18:27, "Wes" <netmo.php@gmail.com> wrote:

Hi Marco \o,

linking to the discussion thread http://externals.io/thread/573 because I
don't have much more to add.

I think the throwable's code is almost never used regardless, but this
could give users more opportunities to do something useful with it as
Niklas stated in previous thread.

Changing PDO errors to be int is an option, too, but I don't see that
happening, not even in a major version. It would be a huge non-bc change
for very very little improvement...

This instead could open up to new uses for the property, that again is
barely used these days, while also fixing the PDO inconsistency.


`Exception#getCode()` is mostly used when re-throwing exceptions as
different exception types, and the API naming makes for very hard searches
for usages on Github too.

In doctrine, we use it to exactly to decide what to throw (specific
exception type).

If you are saying that `getCode` is mostly unused, consider proposing a
deprecation RFC instead, and provide an API specific to your use case as a
replacement.

--001a11443a361b86c50545706bd8--