Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97345
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <933676c1-e828-9eb5-405e-13242fee39a7@lsces.co.uk>
References: <CADxrgCOPNDSKhptKqa-CYF9mOscJHHN+fx19pWyQiqJVdGigCQ@mail.gmail.com>
 <op.yrtb5yadhuszwh@tsukapiou.home> <758680d9-cfe2-4a93-3831-7aa03b4bc9db@nunninger.info>
 <ae327680-59a2-bf5f-bbc9-3afcfa6a6248@beccati.com> <op.yru714ajhuszwh@tsukapiou.home>
 <CADxrgCMQCovAvNRw8hrr0fK9uUTm+jW8Ai_=pGjzt8OMVn6wzQ@mail.gmail.com>
 <CANaX5ndzt+58D87GTqfHy+gNNf9qhaJpdUhp1Q1iB660yqM9ww@mail.gmail.com>
 <CADxrgCORO-Tar9cSKUO=6j+0yuYW6VWigXMt+1zXtD9riHQdWw@mail.gmail.com> <933676c1-e828-9eb5-405e-13242fee39a7@lsces.co.uk>
Date: Thu, 8 Dec 2016 23:27:23 -0500
Message-ID: <CAFp73Xsba1aHTvZJStr+_w507zoijTqp3Q5chKum1jskSYzX+w@mail.gmail.com>
To: Lester Caine <lester@lsces.co.uk>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c07ea18de71d70543322c6d
Subject: Re: [PHP-DEV] Re: [RFC] Debugging PDO Prepared Statement Emulation v2
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

--94eb2c07ea18de71d70543322c6d
Content-Type: text/plain; charset=UTF-8

Hi Adam,

Providing my input on why I voted "NO".
Your proposed new method is not pure. This means it does have distinct
responses depending on where it's located in the code.
That's a big no-no for me.

Cheers,

On Tue, Dec 6, 2016 at 12:15 PM, Lester Caine <lester@lsces.co.uk> wrote:

> On 06/12/16 16:30, Adam Baratz wrote:
> >> This issue is not difficult to solve in userland, at least well enough
> for
> >> debugging in my experience. Here's an older example I wrote up on my
> blog
> >> that worked (but I'm told is broken right now):
> https://daveyshafik.com/
> >> archives/605-debugging-pdo-prepared-statements.html
> >>
> > I want to be able to write .phpt tests that validate how values are
> getting
> > interpolated into emulated prepares. Since this creates a separate code
> > path, it wouldn't let me validate what gets sent to the server.
> > PDO::quote() doesn't necessarily produce the same output as
> > pdo_parse_params().
>
> The whole point of testing is that it tests real results not testing
> 'test code' that tries to emulate the real world. The whole point of
> 'emulated prepare statements' is that it creates a SQL query that the
> target database engine can actually work with rather than one that a
> more capable database engine will process. Testing the innards of some
> driver is simply wrong, one tests the whole process is working! And
> IDEALLY the test suit for PDO should work which ever target is selected,
> but that is not lightly to happen any time soon.
>
> --
> Lester Caine - G8HFL
> -----------------------------
> Contact - http://lsces.co.uk/wiki/?page=contact
> L.S.Caine Electronic Services - http://lsces.co.uk
> EnquirySolve - http://enquirysolve.com/
> Model Engineers Digital Workshop - http://medw.co.uk
> Rainbow Digital Media - http://rainbowdigitalmedia.co.uk
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
Guilherme Blanco
Senior Technical Architect at Huge Inc.

--94eb2c07ea18de71d70543322c6d--