Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:97329 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17984 invoked from network); 7 Dec 2016 21:40:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Dec 2016 21:40:29 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 104.47.38.94 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 104.47.38.94 mail-bl2nam02on0094.outbound.protection.outlook.com Received: from [104.47.38.94] ([104.47.38.94:47904] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BD/00-11772-AC188485 for ; Wed, 07 Dec 2016 16:40:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=RWSoftware.onmicrosoft.com; s=selector1-zend-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=H8GuvwX5Tay2o/9Tl66o0QdE7PnxN8UuwRsp/Giy2m0=; b=LWcnjTuuNueByuO22Iuo/iNEw7lQ0ewvQq+10tYyZ1iVaWNWc7XwNaWCuO62L6Q1VoU1CchARg5BKj4UU4cwnWrG4iEa7pzCfIhXJzgDWP+C2la0C+J6fxIyxB2U/z2rY5KqaaxvSwsZG1NQniCO29H+Z1nQdSth+beYLyDTD5E= Received: from MWHPR02MB2477.namprd02.prod.outlook.com (10.168.204.147) by MWHPR02MB2511.namprd02.prod.outlook.com (10.168.205.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.9; Wed, 7 Dec 2016 21:40:21 +0000 Received: from MWHPR02MB2477.namprd02.prod.outlook.com ([10.168.204.147]) by MWHPR02MB2477.namprd02.prod.outlook.com ([10.168.204.147]) with mapi id 15.01.0761.017; Wed, 7 Dec 2016 21:40:18 +0000 To: "nikita.ppv@gmail.com" , Bob Weinand , Xinchen Hui , "derick@php.net" , "patrickallaert@php.net" , Oz Gilat , Eran Ifrah , Zeev Suraski , "PHP internals list" Thread-Topic: Change in Exception re-throwing Thread-Index: AQHSUNJDh1DJjKASkkq1rKKIl/91lw== Date: Wed, 7 Dec 2016 21:40:18 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=dmitry@zend.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [25.164.163.132] x-microsoft-exchange-diagnostics: 1;MWHPR02MB2511;7:8KYgganJNxxXNSJjtHBakhKah55v24gi9H+PNCJYy+xEZ8PZcFzu8+ABi/Dw9AGBewqMH0OcOiJiRtv1Knwy0pVQMQcQqGK/bfvYpPtGcYWzQZ6JRBNmlZo11HalhRABJGItSFYmMUkT3Pigrl1NDbjflzhlY3lnkv++g4kOPixMMvsj7z7956sVB5sTx1lQ+RWyPfon6oP+8EuxhIKKz4UN2kTYxqEhdbeuahByWM04zKmJ4aQtpXb24Pg581BMHdRa2cuJc9RuvMF3uLecbD1c+4jy4/VyQMbvdDxqvHzZBi7PHCwV56oFt0bddL94ePmAfAaAQVOnjXIQAYXrscBqVWB0SQ0IkZK8TY9d11xqCSB0tkPH1mCJ7Chanzaj0AZupbq83rOu5Z/KMUc6Qfe6ix+EKPST4Yp4yNbhIcOO8TEYo6g9njTbvNMjGdX4yCNHFtLqjoZftbbbV9l3zQ== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10019020)(7916002)(39450400003)(39410400002)(39830400002)(189002)(199003)(7846002)(7736002)(76576001)(3846002)(33656002)(2906002)(19627405001)(66066001)(74316002)(101416001)(106116001)(106356001)(105586002)(99286002)(7906003)(3280700002)(50986999)(6506006)(54356999)(38730400001)(107886002)(3660700001)(606004)(97736004)(5001770100001)(77096006)(2201001)(189998001)(86362001)(39060400001)(6116002)(8676002)(2900100001)(9686002)(5660300001)(7696004)(2501003)(81166006)(102836003)(81156014)(6606003)(8936002)(122556002)(68736007)(92566002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR02MB2511;H:MWHPR02MB2477.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-ms-office365-filtering-correlation-id: cb227552-2efc-4d0d-ecd6-08d41ee9a381 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR02MB2511; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(192278398808882); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148);SRVR:MWHPR02MB2511;BCL:0;PCL:0;RULEID:;SRVR:MWHPR02MB2511; x-forefront-prvs: 01494FA7F7 received-spf: None (protection.outlook.com: zend.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/alternative; boundary="_000_MWHPR02MB24771AD5CFE78E82B5D3ABD7BF850MWHPR02MB2477namp_" MIME-Version: 1.0 X-OriginatorOrg: zend.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2016 21:40:18.3775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2511 Subject: Change in Exception re-throwing From: dmitry@zend.com (Dmitry Stogov) --_000_MWHPR02MB24771AD5CFE78E82B5D3ABD7BF850MWHPR02MB2477namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi, Please take a look into the patch. https://gist.github.com/dstogov/35a480a7= 05b4a96d3d150e4d92dfd1a5 It substitutes calls to zend_throw_exception_internal(NULL) by zend_rethrow= _exeption(). This simplifies code and dosn't change any behavior for PHP itself, however= this may affect some third-party extensions. Now PHP won't call zend_throw_exception_hook(NULL) and DTRACE_EXCEPTION_THR= OWN(NULL) multiple times, during stack unwinding. I think these duplicate calls are completely useless. XDEBUG and APM skip hooks with NULL argument, and are not going to be affec= ted by the patch. If nobody object, I'll commit this into PHP master on Monday. Thanks. Dmitry. --_000_MWHPR02MB24771AD5CFE78E82B5D3ABD7BF850MWHPR02MB2477namp_--