Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:97301 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56085 invoked from network); 6 Dec 2016 03:15:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Dec 2016 03:15:08 -0000 Authentication-Results: pb1.pair.com header.from=morrison.levi@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=morrison.levi@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.172 as permitted sender) X-PHP-List-Original-Sender: morrison.levi@gmail.com X-Host-Fingerprint: 209.85.161.172 mail-yw0-f172.google.com Received: from [209.85.161.172] ([209.85.161.172:32802] helo=mail-yw0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D4/CA-11772-B3D26485 for ; Mon, 05 Dec 2016 22:15:08 -0500 Received: by mail-yw0-f172.google.com with SMTP id r204so265278047ywb.0 for ; Mon, 05 Dec 2016 19:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iIHCDswoDEmVdJrN+2BTL0BYqu+GU4aDMMacblj7nh4=; b=zfJZQ7f5gwbpuGG4bWBDLkjQ5QFOpyJCch9OJO8VsbVwbsmy2u9cS5Y75/77Sqf7dK cCnJo/FdwjCf6CvVxPSUlQ6bJijx1U1jI7J1cVYNDIAD41SSJNPStzIIcFOOqGDLRjV5 iO4IcDz8zHDF/e3J5XjWHJyutSAHjRhqrTbG0S1QBn/arcEaWLHAe6sEEG8LveEN4xyM rNoeFwsT72pV8ICBeLYKHrzZTurTLyYHhtBNJmQkPwfc4H1k8Y4YjYSc0WGVJci5EkQj K3r7xOgYEMA+9nDWjtlarLK88yks+kjE0df6kyzwfZyFt8s8Mw8P+tYaz5hY8Z7RlgHV 4tew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iIHCDswoDEmVdJrN+2BTL0BYqu+GU4aDMMacblj7nh4=; b=gq3X8F+/U7gAL6do/WWWnw2qQwI80BaEwBlfsOoCoD3Awu98qZuOd1o/vVJzgHfdqI kMqywGbrHUdeUMow5SOhBrMEe0fdd7ro/zpEdwYbtSk+i4a6wdfwSCs3IikyTq9NAB7U DnLADgBO/JxNXpkC9RGFX7Vcv0txYawOpdGVBwn6ldzSf1rkPwmdHNxST8KkUxXLolDq UzcrbFjv3sQXe5tR6B0/x3HYUlmmzUbsA7eNBmYHsCe0ApQl3n1wgXIrDgTxtWZLT5m7 a1Nzrnnp4dM0w4F8b1/LlBj6kUxVHioAkJvcJEQajgd4Wg6GV4IVdS24XAkLPZUQFEeo XGLw== X-Gm-Message-State: AKaTC02qauuQnmN7/JSPt5PZHBeVCOUDIyBmD1TR4fUcTZ5idqc3ra7f07OSspedlvCZB+69IZSCPrEaE/qSbQ== X-Received: by 10.13.252.131 with SMTP id m125mr57223049ywf.117.1480994104632; Mon, 05 Dec 2016 19:15:04 -0800 (PST) MIME-Version: 1.0 Sender: morrison.levi@gmail.com Received: by 10.129.197.69 with HTTP; Mon, 5 Dec 2016 19:15:04 -0800 (PST) In-Reply-To: References: Date: Mon, 5 Dec 2016 20:15:04 -0700 X-Google-Sender-Auth: nSoVw-CqT_Iqbrr3uG7mK38jH6k Message-ID: To: Yasuo Ohgaki Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][VOTE] User defined session serializer From: levim@php.net (Levi Morrison) On Mon, Dec 5, 2016 at 8:02 PM, Yasuo Ohgaki wrote: > Hi Levi, > > On Tue, Dec 6, 2016 at 11:52 AM, Levi Morrison wrote: >>>> These are not consistent with return type checking. This *must* reuse >>>> the error checking that is already in-place and not provide something >>>> new to accomplish the same thing. >>> >>> What do you mean by inconsistent? >> >> We do not use E_RECOVERABLE_ERROR for return type mismatches; we use >> TypeError. That is the inconsistency. > > It depends. Session module uses errors rather than exceptions. Mixing > them is inconsistent for a module. > > I wrote I prefer exceptions and I'll handle error handling issue > (error -> exception) with other RFC during discussion. So don't worry > about it for now. Currently all return types use TypeError when they do not match. Do not introduce anything different; we do not need any more special cases than we already have.