Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97231
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <7eaa3b8f-7e21-a50c-946e-3f721db09a10@beccati.com>
References: <CADxrgCOPNDSKhptKqa-CYF9mOscJHHN+fx19pWyQiqJVdGigCQ@mail.gmail.com>
 <CADxrgCN8UBp5c5F1nmSm7EekUfjtQtzdc0zE5HPJfxjZT3KNAw@mail.gmail.com>
 <aa8ad80b-b9a0-2416-4148-b43f251b3b0d@beccati.com> <CADxrgCO3M2YVCCcsSLG66a49FXjPfQZPDWPEoc8qFYbiAwUunQ@mail.gmail.com>
 <7eaa3b8f-7e21-a50c-946e-3f721db09a10@beccati.com>
Date: Wed, 30 Nov 2016 17:48:29 -0500
Message-ID: <CADxrgCNMnOUG=1Sxiy2wdT_jckz+K3Kd6_Sb66zXHNL4Erycjw@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c0b6202f3f5a105428c8083
Subject: Re: [PHP-DEV] Re: [RFC] Debugging PDO Prepared Statement Emulation v2
From: adambaratz@php.net (Adam Baratz)

--94eb2c0b6202f3f5a105428c8083
Content-Type: text/plain; charset=UTF-8

Hi,

> Basically, you'd never see this kind of example:
> >
> > SQL: "SELECT * FROM tbl WHERE x = ?"
> >> Sent SQL: "SELECT * FROM tbl WHERE x = $1"
> >>
>
> why not? That's what active_query_string contains e.g. in pdo_pgsql w/o
> emulate prepares. Which is more or less what has been sent to the
> server, unless cursors are used. I don't see why it is deemed to be
> not-useful or less useful than emulated prepares.
>

active_query_string is only set with emulated prepares. I tried my patch
with pdo_pgsql. "Sent SQL" doesn't appear with real prepares. I put it up
here, with tests, if it'll help try it out:
https://github.com/adambaratz/php-src/commit/a030d2f4e6a13f3e6c10484fb5dbc4e8be6576c6

I'll incorporate it, and the content of this subthread, in the RFC when I
get my next free five minutes. :)

In fact it would come in very handy for extended tests of a bugfix I
> have in the pipeline.
>

I'm not sure how to get the query with the $1. My understanding of
pdo_pgsql/pgsql_stmt_execute() is that it creates some PG-specific data
structures for prepared statements. Since they're attached to
a pdo_pgsql_stmt value, you'd have to write some driver-specific code to
get them out.

Maybe there's a simple way to do what you're describing, but my instinct is
that it would be better to keep it out-of-scope for this RFC.

Thanks,
Adam

--94eb2c0b6202f3f5a105428c8083--