Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97221
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <aa8ad80b-b9a0-2416-4148-b43f251b3b0d@beccati.com>
References: <CADxrgCOPNDSKhptKqa-CYF9mOscJHHN+fx19pWyQiqJVdGigCQ@mail.gmail.com>
 <CADxrgCN8UBp5c5F1nmSm7EekUfjtQtzdc0zE5HPJfxjZT3KNAw@mail.gmail.com> <aa8ad80b-b9a0-2416-4148-b43f251b3b0d@beccati.com>
Date: Mon, 28 Nov 2016 18:16:36 -0500
Message-ID: <CADxrgCO3M2YVCCcsSLG66a49FXjPfQZPDWPEoc8qFYbiAwUunQ@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1143d318d104d1054264a9a6
Subject: Re: [PHP-DEV] Re: [RFC] Debugging PDO Prepared Statement Emulation v2
From: adambaratz@php.net (Adam Baratz)

--001a1143d318d104d1054264a9a6
Content-Type: text/plain; charset=UTF-8

Hi,

I would not use "Parsed SQL" though, as it's not just the result of
> parsing. In fact it could effectively be what has been sent to the backend,
> regardless of statement emulation...
>

I'd be happy to make the feature more specific. The "Parsed" line would
only show with emulated prepares enabled, after execute() has been called.
I'd prefer using "Parsed" because the language would be more specific. It
would also correspond to pdo_parse_params(), the function which does the
emulation.

Basically, you'd never see this kind of example:

SQL: "SELECT * FROM tbl WHERE x = ?"
> Sent SQL: "SELECT * FROM tbl WHERE x = $1"
>

I haven't tested, but I'm pretty sure the feature could be implemented by
adding this block below the first php_stream_printf() call in
debugDumpParams():

/* show parsed SQL if emulated prepares enabled */
> /* pointers will be equal if PDO::query() was invoked */
> if (stmt->active_query_string != NULL && stmt->active_query_string !=
> stmt->query_string) {
>   php_stream_printf(out, "Parsed SQL: [%zd] %.*s\n",
> stmt->active_query_stringlen, (int) stmt->active_query_stringlen,
> stmt->active_query_string);
> }


Let me know what you think of this approach. If it sounds fine, I'll update
the RFC.

Thanks,
Adam

--001a1143d318d104d1054264a9a6--