Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97220
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.123.236 as permitted sender)
To: Adam Baratz <adambaratz@php.net>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <CADxrgCOPNDSKhptKqa-CYF9mOscJHHN+fx19pWyQiqJVdGigCQ@mail.gmail.com>
 <CADxrgCN8UBp5c5F1nmSm7EekUfjtQtzdc0zE5HPJfxjZT3KNAw@mail.gmail.com>
Message-ID: <aa8ad80b-b9a0-2416-4148-b43f251b3b0d@beccati.com>
Date: Mon, 28 Nov 2016 17:05:07 +0100
MIME-Version: 1.0
In-Reply-To: <CADxrgCN8UBp5c5F1nmSm7EekUfjtQtzdc0zE5HPJfxjZT3KNAw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [RFC] Debugging PDO Prepared Statement Emulation v2
From: php@beccati.com (Matteo Beccati)

Hi Adam,

On 28/11/2016 16:29, Adam Baratz wrote:
>> Based on my second thoughts on my initial approach, I created an RFC to
>> supplant it:
>> https://wiki.php.net/rfc/debugging_pdo_prepared_statement_emulation_v2
>>
> 
> I'd appreciate any feedback on this RFC, especially from any of the people
> who voted against the original[1].

v2 seems more reasonable to me. I would not use "Parsed SQL" though, as
it's not just the result of parsing. In fact it could effectively be
what has been sent to the backend, regardless of statement emulation...
however, nothing better than "Sent SQL" comes to mind atm.

I.e. in case of pdo_pgsql:

SQL: "SELECT * FROM tbl WHERE x = ?"
Sent SQL: "SELECT * FROM tbl WHERE x = $1"

(could be available before execute)

or w/ emulated prepares:

Sent SQL: "SELECT * FROM tbl WHERE x = 'foo'"

(only available after execute)

For consistency, I would prefer to only add the information after
execute() has been called.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/