Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97194
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.43 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CAJW__o3qa=Fio_ZenLvVhL=DXiD=e-r8haxUcLEq2pjVib8xwQ@mail.gmail.com>
References: <56e89e82-00aa-5521-f014-14cf4d588157@cubiclesoft.com>
 <CAJW__o2vn0PGJEYQ8-qojYCBTd7Czjf193NEzzaCqK+NHEHZ6A@mail.gmail.com>
 <5d865bc1-dc06-54b8-800e-99f1c2914632@cubiclesoft.com> <CAJW__o3qa=Fio_ZenLvVhL=DXiD=e-r8haxUcLEq2pjVib8xwQ@mail.gmail.com>
Date: Fri, 25 Nov 2016 23:32:49 +0000
Message-ID: <CAEKnhAFbXaydKSNP2pmDLnDnhx7M+vTVXiUhwcHCNX=ooHiKpA@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Thomas Hruska <thruska@cubiclesoft.com>, PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c0cccc248180c0542288a53
Subject: Re: [PHP-DEV] Translating optional zval ** with zend_parse_parameters()
 to PHP 7
From: bukka@php.net (Jakub Zelenka)

--94eb2c0cccc248180c0542288a53
Content-Type: text/plain; charset=UTF-8

On 25 Nov 2016 20:43, "Kalle Sommer Nielsen" <kalle@php.net> wrote:

2016-11-25 13:30 GMT+01:00 Thomas Hruska <thruska@cubiclesoft.com>:
> I need to be able to *modify* the original variable that was passed in.
I already use "|l" and zend_long
> elsewhere in the extension

Ah my bad I misread it!

In that case take a look at where such is implemented in php-src,
dns_get_record() is an example despite the slightly clouded code:
http://git.php.net/?p=php-src.git;a=blob;f=ext/standard/dns.c;h=
f92015eee90d3e93a801e93d6381d89923825166;hb=refs/heads/master#l1011

See $weight_list:

- Check if the argument is passed
- zval_dtor()
- Populate it (ZVAL_LONG is the same)

The main difference from your code is to use 'z' (lower case) in ZPP,
and then use zval* (which is what 'z' returns).



You also need set 1 for the first param of ZEND_ARG_INFO (specify that it
is a ref param) otherwise it won't use the changed val...

Jakub

--94eb2c0cccc248180c0542288a53--