Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97170
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.169 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <56e89e82-00aa-5521-f014-14cf4d588157@cubiclesoft.com>
References: <56e89e82-00aa-5521-f014-14cf4d588157@cubiclesoft.com>
Date: Fri, 25 Nov 2016 08:27:24 +0100
Message-ID: <CAJW__o2vn0PGJEYQ8-qojYCBTd7Czjf193NEzzaCqK+NHEHZ6A@mail.gmail.com>
To: Thomas Hruska <thruska@cubiclesoft.com>
Cc: PHP Development <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Translating optional zval ** with zend_parse_parameters()
 to PHP 7
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Thomas

2016-11-25 4:13 GMT+01:00 Thomas Hruska <thruska@cubiclesoft.com>:
> I'm working on updating an extension for PHP 7 compatibility.  I have one
> function that uses an optional zval ** with zend_parse_parameters().
>
>         zval **zprevcount = NULL;
>         int count;
>         int argc = ZEND_NUM_ARGS();
>
>         if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|Z",
> &zprevcount) == FAILURE)  return;
>
>         ...
>
>         if (argc > 0)
>         {
>                 count = (int)PrevCount;
>
>                 zval_dtor(*zprevcount);
>                 ZVAL_LONG(*zprevcount, count);
>         }
>
> What's the correct way to translate that into PHP 7?

Since you are working with integers, you can do:

zend_long prevcount = 0;

if(zend_parse_parameters(ZEND_NUM_ARGS(), "|l", &prevcount) == FAILURE)
{
        return;
}

if(prevcount)
{
      /* ... use prevcount ... */
}

Notice that all integers returned from the ZPP is a zend_long, you can
see more information about the ZPP in
php-src/README.PARAMETER_PARSING_API

-- 
regards,

Kalle Sommer Nielsen
kalle@php.net