Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:97168
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain axot.org from 74.125.83.47 cause and error)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\))
Message-ID: <AE10FAD8-E0FB-4400-8D0F-3B413D301EE1@axot.org>
Date: Fri, 25 Nov 2016 14:40:56 +0900
To: internals@lists.php.net
Subject: How to handle error in sapi
From: axot@axot.org (Zheng Shao)

Hi,

I'm working on fix this bug (https://bugs.php.net/bug.php?id=3D61471) =
both on PHP-7 and PHP-5.6.
The problem is `ap_get_brigade` will return an error when connection =
timeout happened.

in `sapi/apache2handler/sapi_apache2.c`:

static int
php_apache_sapi_read_post(char *buf, uint count_bytes TSRMLS_DC)
{
	apr_size_t len, tlen=3D0;
	php_struct *ctx =3D SG(server_context);
	request_rec *r;
	apr_bucket_brigade *brigade;
+	apr_status_t ret;
+	int error;

	r =3D ctx->r;
	brigade =3D ctx->brigade;
	len =3D count_bytes;

	/*
	 * This loop is needed because ap_get_brigade() can return us =
partial data
	 * which would cause premature termination of request read. =
Therefor we
	 * need to make sure that if data is available we fill the =
buffer completely.
	 */

-	while (ap_get_brigade(r->input_filters, brigade, =
AP_MODE_READBYTES, APR_BLOCK_READ, len) =3D=3D APR_SUCCESS) {
+	while ((ret=3Dap_get_brigade(r->input_filters, brigade, =
AP_MODE_READBYTES, APR_BLOCK_READ, len)) =3D=3D APR_SUCCESS) {
		apr_brigade_flatten(brigade, buf, &len);
		apr_brigade_cleanup(brigade);
		tlen +=3D len;
		if (tlen =3D=3D count_bytes || !len) {
			break;
		}
		buf +=3D len;
		len =3D count_bytes - tlen;
	}

+       if (ret !=3D APR_SUCCESS){
+               if (APR_STATUS_IS_TIMEUP(ret)) {
+                       error =3D ap_map_http_request_error(ret, =
HTTP_REQUEST_TIME_OUT);
+               } else {
+                       error =3D ap_map_http_request_error(ret, =
HTTP_BAD_REQUEST);
+               }
+               // HOW TO HANDLE ERROR HERE, should I throw a =
zend_throw_exception?
+               // zend_throw_exception(NULL, "Read POST data error", =
error);
+       }
	return tlen;
}

@@ -616,6 +625,7 @@ zend_first_try {
                ctx->brigade =3D brigade;

                if (php_apache_request_ctor(r, ctx TSRMLS_CC)!=3DSUCCESS) =
{
+                       // HANDLE zend_throw_exception TIMEOUT HERE ?
                        zend_bailout();
                }
        } else {
@@ -627,6 +637,7 @@ zend_first_try {
                                strcmp(parent_req->handler, =
PHP_SOURCE_MAGIC_TYPE) &&
                                strcmp(parent_req->handler, PHP_SCRIPT)) =
{
                        if (php_apache_request_ctor(r, ctx =
TSRMLS_CC)!=3DSUCCESS) {
+                               // HANDLE zend_throw_exception TIMEOUT =
HERE ?
                                zend_bailout();
                        }
                }

I'm confused by how to handle an error inside php_apache_sapi_read_post, =
shoud I throw a zend_throw_exception or use a global flag for error =
handling?

Thank you

--=20
Zheng SHAO
axot@axot.org=