Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96896
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 104.47.34.119 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>
CC: Zeev Suraski <zeev@zend.com>, "php-dev@coydogsoftware.net"
	<php-dev@coydogsoftware.net>, Julien Pauli <julienpauli@gmail.com>,
	"rasmus@lerdorf.com" <rasmus@lerdorf.com>, "Anatol Belski (ab@php.net)"
	<ab@php.net>, Dmitry Stogov <dmitry@zend.com>, Nikita Popov <nikic@php.net>,
	Joe Watkins <pthreads@pthreads.org>, "internals@lists.php.net"
	<internals@lists.php.net>
Thread-Topic: [PATCH] opcache bug #69090, prepend user identifier to keys
Thread-Index: AQHSP2OhD4h3upkAiEqzeDgxtnu8Qg==
Date: Tue, 15 Nov 2016 17:32:54 +0000
Message-ID: <MWHPR02MB247723E856E0DAF7639F0E26BFBF0@MWHPR02MB2477.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [25.164.163.132]
x-microsoft-exchange-diagnostics:
	1;MWHPR02MB2478;6:1TYVb9n0WKfuNLQbzJ2A6pZwq1KCRBAAJjOKto+WFrMs8VEKVpj5V/PCbWmqgjtKwULd2D/TfGMXLG84ValnffqXv1OzfPn7vfL+xpfopnqvZxnAglkxRNS5pa378mfPfSIOC5IgJgenOX3Paw9CKFZ73spOf1Hux157YQf5FwZV9MKKNyKnsLR4c3d25Y3DreqK9Esb8550wXDCW3RQjEZ7YWuJKhzy+Y5kR2I+9AGbYJZFaEyfj9qpTtihuMA/wMVYQ8TyDOtE9QUbcgNlnGOk2wHElqq4gwKPtCyhpndoZsmC+z/cUosvF+Y5GXN6;5:g+JsDLkEEoyIpOBwpRzvZ2gFNa2gx8m8Y4ycHLuLpyO5fHC7WfsaITv9AmF4mPzlqi0geTjiqLaZ3lK0EDb6XkbIl9nEWpXv+I/kwgFagbfl4V5pdbvttnh+rZcjndepWagZfy5UmwRPtqBhKwIEnw==;24:QHAImIx9aVSA76gAJzVg2GdY2cp4Bf2PZJUM+3vvuSSwSCgrGIGyrdoCzNdtlJDY4lIJM06IYFbUeXvdxkkXN9vRdn3w515t4/hYHXIu5J4=;7:0evJ0yHhOOD9KwnRd/sUzLoAubUqBMhpRu+2oXsTxnsK2qdFXTXKrykQXTx+S1cWrTBSDPIRriVPeP6jpShlXgqM/18FQgIDLbKnTTvbXOAznq1Ug9rLxVS/bGKY2zl1bRx038Xn5A3A/qhPIMz4DZ7N1UORLutKtidtCtbm8aInzIx1m2EwLgdr/4SUqHCgiusAKhmJA2e3hewu3GHLuQxaI0AGAtUfG1X8PPhIvqU4bmFhoTLDG4PA86y/BJY78zLqTDTmJVx9QxHGyFEOd89hvQL8hofFE8ah7+LSSGQE1YsrIuqxmdXQAbALAfhmCGl/XIyZIAz87o8drIs6LmB+XiP86rIejNNZ1oYx5Ok=
x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10019020)(6009001)(7916002)(189002)(377454003)(199003)(24454002)(7736002)(76576001)(86362001)(106356001)(106116001)(99286002)(105586002)(74316002)(6606003)(7696004)(3660700001)(5660300001)(102836003)(33656002)(110136003)(189998001)(122556002)(3846002)(3280700002)(6116002)(92566002)(77096005)(97736004)(2900100001)(7846002)(19627405001)(4326007)(2906002)(6916009)(81156014)(101416001)(8676002)(229853002)(87936001)(50986999)(68736007)(81166006)(5890100001)(54356999)(8936002)(66066001)(9686002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR02MB2478;H:MWHPR02MB2477.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en;
x-ms-office365-filtering-correlation-id: 0f6477df-9dc6-44ab-c80b-08d40d7d6efa
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR02MB2478;
x-microsoft-antispam-prvs: <MWHPR02MB24789346FCC67035CA1D9D9EBFBF0@MWHPR02MB2478.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:MWHPR02MB2478;BCL:0;PCL:0;RULEID:;SRVR:MWHPR02MB2478;
x-forefront-prvs: 012792EC17
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_MWHPR02MB247723E856E0DAF7639F0E26BFBF0MWHPR02MB2477namp_"
MIME-Version: 1.0
X-OriginatorOrg: zend.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2016 17:32:54.6671
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2478
Subject: Re: [PATCH] opcache bug #69090, prepend user identifier to keys
From: dmitry@zend.com (Dmitry Stogov)

--_000_MWHPR02MB247723E856E0DAF7639F0E26BFBF0MWHPR02MB2477namp_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

On Nov 15, 2016 18:50, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> On Tue, Nov 15, 2016 at 4:19 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>>
>> New patch, attached to bug report, should fix both problems.
>>
>> I'm going to commit it tomorrow, if no objections.
>>
>>
>> Thanks. Dmitry.
>
> For the new validate_root patch, wouldn't we still end up with inode coll=
isions caused by the hash function? It looks like for inodes > 2^16 collisi=
ons should be "common".
>
> Nikita


It's not a problem to add inode check, but I think we don't need it.


Let S1 and S2 strings, R1 and R2 root_hashes and F a hash function.

You propose the following comparison for collision checks


F(S1) ^ R1 =3D=3D F(S2) ^ R2 && R1 =3D=3D R2 && S1 =3D=3D S2


R1 =3D=3D R2 seems useless. The existing condition:


F(S1) ^ R1 =3D=3D F(S2) ^ R2 && S1 =3D=3D S2


fails if S1 !=3D S2 independently on R1 and R2.

If S1 and S2 are the same, than F(S1) equal to F(S2) and consequently, to s=
atisfy the whole condition, R1 should be equal to R2


Am I wrong?


Thanks. Dmitry.

--_000_MWHPR02MB247723E856E0DAF7639F0E26BFBF0MWHPR02MB2477namp_--