Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96894 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40942 invoked from network); 15 Nov 2016 15:50:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Nov 2016 15:50:33 -0000 Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.66 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 74.125.82.66 mail-wm0-f66.google.com Received: from [74.125.82.66] ([74.125.82.66:35681] helo=mail-wm0-f66.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 39/53-05303-9CE2B285 for ; Tue, 15 Nov 2016 10:50:33 -0500 Received: by mail-wm0-f66.google.com with SMTP id a20so1179833wme.2 for ; Tue, 15 Nov 2016 07:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZOaEaO7icP3TQeUgnMFnwuUws1jTp4DsF2b0ERWFxqE=; b=Hpi/u78UHfLYPp3FVF4ZGBwVtQn8mAgz/j34QCgh5shdJtF2qNg0WOnV9ksMLMLfM1 wkEjCdNMJIsdu1Bnk0rZpEoBx0MlQj7zcYMbDqKU3H0QWNdAW0pyRTi9u5Qd5puvdDOf /uMV9kDWvAZ3egR06FJNkZt5X58iOWAOdDvgMmTp1R2ZT8RfJ5eJnp7rpzpHhHvdGQ59 Ef5VW3HcN7/Di7ublyBFn0nxPqDmxx7Tu666uIotc6A/tPn/dIhvHgfLWiw24Xsqhn6u Y3VLAdCmqGgOC+zLmc3co8XFsTSy69GC55PybKPtZRksMr70CqKg98dL33FoHyKg6XB5 n1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZOaEaO7icP3TQeUgnMFnwuUws1jTp4DsF2b0ERWFxqE=; b=kPs/c+Rr06zBB4JXcoRao/poKD/j8ahVLzZfNYU4JSPMMtYVnUf7BexzyxcP8TMMHW qmUiYeHh1zajP0YVjNK8TO0Zk3TIOMRVSReDaFV5zs1baZh0SSyCnQkagUEZAj+IiHO2 peJXJH7hLW5DZNcMujH4NDyvXpAKP9Pevfe/+R2vCbe38ivT8O1hxh5H3k2otNKbwfpc k20dWaD6+/0XKwTAzAtN9YBLrSA+iQRzKALwhAZOevi3bZY7hvnOeCV6G5gkbuOtTZi6 UWGMpJ8uwWJdDRqsUiHmVb0W8D0GF/FVspZx7mx9LdYKZtzoEBD4sSsB+XhmRN7PQeZX 4uoQ== X-Gm-Message-State: ABUngven7oCY0QCFOM91c3D1v9u+qUVn7tTk94MoAGdVCtjRRMc3cxs2RVyWD8VrPEemHXsNfoBNgKQOoymgNw== X-Received: by 10.194.174.229 with SMTP id bv5mr11650296wjc.21.1479225030429; Tue, 15 Nov 2016 07:50:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.170.79 with HTTP; Tue, 15 Nov 2016 07:50:29 -0800 (PST) In-Reply-To: References: <20161111130329.GA22968@sliver.coydogsoftware.net> Date: Tue, 15 Nov 2016 16:50:29 +0100 Message-ID: To: Dmitry Stogov Cc: "php-dev@coydogsoftware.net" , "rasmus@lerdorf.com" , "internals@lists.php.net" , "Anatol Belski (ab@php.net)" , Zeev Suraski , Nikita Popov , Julien Pauli , Joe Watkins Content-Type: multipart/alternative; boundary=089e0141aa247b6c7e054158ea4c Subject: Re: [PATCH] opcache bug #69090, prepend user identifier to keys From: nikita.ppv@gmail.com (Nikita Popov) --089e0141aa247b6c7e054158ea4c Content-Type: text/plain; charset=UTF-8 On Tue, Nov 15, 2016 at 4:19 PM, Dmitry Stogov wrote: > New patch, attached to bug report, should fix both problems. > > I'm going to commit it tomorrow, if no objections. > > > Thanks. Dmitry. > For the new validate_root patch, wouldn't we still end up with inode collisions caused by the hash function? It looks like for inodes > 2^16 collisions should be "common". Nikita --089e0141aa247b6c7e054158ea4c--