Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:96805 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21643 invoked from network); 10 Nov 2016 07:34:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Nov 2016 07:34:57 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:53250] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BA/FD-15787-E1324285 for ; Thu, 10 Nov 2016 02:34:56 -0500 Received: (qmail 82188 invoked by uid 89); 10 Nov 2016 07:34:51 -0000 Received: from unknown (HELO mail-wm0-f43.google.com) (yohgaki@ohgaki.net@74.125.82.43) by 0 with ESMTPA; 10 Nov 2016 07:34:51 -0000 Received: by mail-wm0-f43.google.com with SMTP id g23so23519208wme.1 for ; Wed, 09 Nov 2016 23:34:50 -0800 (PST) X-Gm-Message-State: ABUngvcIJcaNcyfPK8Wjs35PLmqQqgVqy9L7TPXfur7bNuCuTvebg8rPyEtwHl5+Sf1cPu1VQJWf9y5VE/2fRA== X-Received: by 10.28.232.213 with SMTP id f82mr23296223wmi.85.1478763283843; Wed, 09 Nov 2016 23:34:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.190.200 with HTTP; Wed, 9 Nov 2016 23:34:03 -0800 (PST) Date: Thu, 10 Nov 2016 16:34:03 +0900 X-Gmail-Original-Message-ID: Message-ID: To: "internals@lists.php.net" Cc: Davey Shafik Content-Type: text/plain; charset=UTF-8 Subject: Disable session save handler abuses From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi all, This PR disables recursive session save handler function calls (any multiple/invalid session save handler function calls) https://github.com/php/php-src/pull/2196 This patch disables many kinds of save handler function abuses and user script bugs. We have/had many bugs related to this patch, including number of save handler function related crashes. It also allows to call session_create_id() in user save handler function. Currently, SID creation save handler assumes to generate session ID from scratch. With this patch, users can use session_create_id() to generate new ID of their own. e.g. User ID prefixed session ID, $newid = $user_id.session_create_id() in SID creation save handler. I would like to merge this fix from 7.1, at least required module global var definition so that it can be fixed later. diff --git a/ext/session/php_session.h b/ext/session/php_session.h index da5e485..775527c 100644 --- a/ext/session/php_session.h +++ b/ext/session/php_session.h @@ -205,6 +205,7 @@ typedef struct _php_ps_globals { zend_bool use_strict_mode; /* whether or not PHP accepts unknown session ids */ zend_bool lazy_write; /* omit session write when it is possible */ zend_string *session_vars; /* serialized original session data */ + zend_bool in_save_handler; /* state that if session is in save handler or not */ } php_ps_globals; Any comments? Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net