Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96790
Return-Path: <nikita.ppv@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 53642 invoked from network); 9 Nov 2016 16:12:44 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 9 Nov 2016 16:12:44 -0000
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.51 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@gmail.com
X-Host-Fingerprint: 74.125.82.51 mail-wm0-f51.google.com  
Received: from [74.125.82.51] ([74.125.82.51:38192] helo=mail-wm0-f51.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id AE/35-15787-CFA43285 for <internals@lists.php.net>; Wed, 09 Nov 2016 11:12:44 -0500
Received: by mail-wm0-f51.google.com with SMTP id f82so251861021wmf.1
        for <internals@lists.php.net>; Wed, 09 Nov 2016 08:12:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=sdRh+fZQgCJwJQ9V3t+uDzz6WC60mjqcZ3Ae7GJuH1c=;
        b=WKvIgIOjVOQ9tz16smoZfSEZC39+j1XdZfHHwW5+FgHblB10t2sdVzWpyimAbTFZfJ
         SJBlsvDTnXN98HEtXT9hutnA8wqEzruQosJu9NmY6kiuB2wFfKhg2OseAs1KhCGwxUoQ
         SjpgktIRobiCQFCZoUdY67GNXsyQ99Uyq6aupNYc6RhGUAuBIG2BViqqTkuzMzQbl+9u
         zZl/EawbqshN2il6Px3woLt+fb5VTzQ9bBxvi08bEFtRWv2lyRq5xpUt6VjPks1LKhKA
         bETq4KJKsMjk2DRH+QtJG2InXfqTQi/iwMQLZguylph6yiy/U3StTi2z2NplIkTV74gj
         UK4Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=sdRh+fZQgCJwJQ9V3t+uDzz6WC60mjqcZ3Ae7GJuH1c=;
        b=g2l6/jQsOrZNbogBJ1oHgYtts53Cues2SbDZjKsbQPhoxYAiIRhMayyyTdizsTzoN+
         wsPh7lWD4fF73o4NVxZ1Q4fM1kjZU3hreviw+n36IIwaE3Y3LcMRcB8/g0lbOKwLuA9X
         B8eCjs91SEBkY/aVja7JuUKjVRT1m0GCbBe+M8q5ZeT1CgLOD1MsQgML4IUoeVKqelXd
         p3Av+GJ+7KJjmq4guILX2YgdrWWlH5Jc6gekeAap5398eQ6wtSOPw5NKjbyhxWUHa0Sd
         SABzftzGApgF1H5zsQ8/NrWSgNDK0zm7YfeTFyJ66Yd7DOX9Nh3rhkyQicaO0q/Yurj0
         7Z3Q==
X-Gm-Message-State: ABUngvdETmCENwOYFix6BjO81mGc1gmuThv6gaKM4b34uY0JtflX3vKdrUvWkz1tpq7dUjce1MOhwfpV2UwhPA==
X-Received: by 10.28.93.202 with SMTP id r193mr23628245wmb.30.1478707961577;
 Wed, 09 Nov 2016 08:12:41 -0800 (PST)
MIME-Version: 1.0
Received: by 10.80.170.79 with HTTP; Wed, 9 Nov 2016 08:12:40 -0800 (PST)
In-Reply-To: <alpine.DEB.2.20.1611091508140.5688@whisky.home.derickrethans.nl>
References: <alpine.DEB.2.20.1611091403200.5688@whisky.home.derickrethans.nl>
 <cfcea58d-9a5b-5649-be4c-5181d33cad78@gmx.de> <alpine.DEB.2.20.1611091508140.5688@whisky.home.derickrethans.nl>
Date: Wed, 9 Nov 2016 17:12:40 +0100
Message-ID: <CAF+90c_+-eQbttdgqjG_1250wLeF8a-wwQCHqFC2cD5vYyCDxA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, 
	PHP Developers Mailing List <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=001a1146d9cec6c7f00540e08630
Subject: Re: [PHP-DEV] Re: PHP 5.6 static access valgrind issue
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1146d9cec6c7f00540e08630
Content-Type: text/plain; charset=UTF-8

On Wed, Nov 9, 2016 at 4:09 PM, Derick Rethans <derick@php.net> wrote:

> On Wed, 9 Nov 2016, Christoph M. Becker wrote:
>
> > On 09.11.2016 at 15:21, Derick Rethans wrote:
>
> <snip>
>
> > > And running it with "valgrind php -n index.php", produces:
> > >
> > >     root@debian-8-64bit:/home/derick/xdebug-issue-1185# valgrind php
> -n index.php
> > >     ==760== Memcheck, a memory error detector
> > >     ==760== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward
> et al.
> > >     ==760== Using Valgrind-3.10.0 and LibVEX; rerun with -h for
> copyright info
> > >     ==760== Command: php -n index.php
> > >     ==760==
> > >     ==760== Conditional jump or move depends on uninitialised value(s)
> > >     ==760==    at 0x797992: zend_std_get_static_method
> (zend_object_handlers.c:1261)
> > >     ==760==    by 0x7B66FE: ZEND_INIT_STATIC_METHOD_CALL_SPEC_CONST_CONST_HANDLER
> (zend_vm_execute.h:3887)
> > >     ==760==    by 0x7A379F: execute_ex (zend_vm_execute.h:363)
> > >     ==760==    by 0x76E2AF: zend_execute_scripts (zend.c:1341)
> > >     ==760==    by 0x70CC87: php_execute_script (main.c:2613)
> > >     ==760==    by 0x81A990: do_cli (php_cli.c:998)
> > >     ==760==    by 0x431996: main (php_cli.c:1382)
> > >     ==760==
>
> > zend_std_get_static_method() declares use_heap[1] (if there's support
> > for alloca), but doesn't initialize it with SET_ALLOCA_FLAG()[2].  It
> > seems to me that ALLOCA_FLAG()[3] should be defined like so:
> >
> >   # define ALLOCA_FLAG(name) \
> >     zend_bool name = 0;
>
> That sounds about right - Dmitry, Nikita?
>

This shouldn't be a problem. alloca is only used in the !key branches, in
which case the flag is initialized by do_alloca.


>
> > > I'm going to see whether PHP 7.0 and 7.1 have a similar issue too.
>
> It seems like there is a similar issue in PHP 7.0 and 7.1 too, looking
> at the source.
>
> cheers,
> Derick
>

--001a1146d9cec6c7f00540e08630--