Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96775
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.213.180 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <0e8fbcf4-1bcf-02e6-9323-ddd910506ddb@librelamp.com>
References: <46.92.05967.9AB91285@pb1.pair.com> <CA+kxMuR1wVzyAA3RkN2VxmgUNFDm2Z-h02HChFVwT+=imxG4dQ@mail.gmail.com>
 <DB.40.23587.332C1285@pb1.pair.com> <0e8fbcf4-1bcf-02e6-9323-ddd910506ddb@librelamp.com>
Date: Tue, 8 Nov 2016 10:08:06 -0800
Message-ID: <CANaX5nen1hwetaL-F_tJzMcDMACZGnD6xa-T2yX9sr4nYUxaoA@mail.gmail.com>
To: Alice Wonder <alice@librelamp.com>, Joe Watkins <krakjoe@php.net>, 
	Derick Rethans <derick@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114bc86cbb5dc70540ce056d
Subject: Re: [PHP-DEV] DateTime microseconds discussion
From: davey@php.net (Davey Shafik)

--001a114bc86cbb5dc70540ce056d
Content-Type: text/plain; charset=UTF-8

On Tue, Nov 8, 2016 at 6:28 AM, Alice Wonder <alice@librelamp.com> wrote:

> On 11/08/2016 04:16 AM, Arjen Schol wrote:
>
>> Hi Dan,
>>
>> I think you make some bad assumptions here. The examples provided by
>> Sjon are scripts submitted to 3v4l.org They may have bad assumptions,
>> but are real life examples of DateTime usage. And they will break.
>>
>
> They are already broken. That's the point.
>
> Rarely will the current breakage trigger but it will trigger.
>
> Personally I prefer it when bad code obviously triggers, it can be very
> difficult (read expensive) to track bugs in code that only rarely and
> randomly trigger.


I have discussed this with Joe, and we are OK with the warning BC break;
everything else is not considered a BC break.

We should definitely document some best practices around relative dates,
e.g. using midnight, or explicitly setting the time.

Thanks,

- Davey

--001a114bc86cbb5dc70540ce056d--