Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96669
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fleshgrinder.com from 77.244.243.85 cause and error)
Reply-To: internals@lists.php.net
References: <44244cfd-c8ad-e0a9-4e70-380a8a8c940c@syberisle.net>
 <CAFMT4Nr+d1k20aY0P9o1G9KU_C9wz2cg2UOPrbE3qbXDBhqe3w@mail.gmail.com>
 <CAF+90c_7g_YdxTfUX8t_OifVJTL=OcvjsC_smWc95M-CcRYaNw@mail.gmail.com>
 <CADqTB_jN6RQxEP5tAJY4T+kuv_rkTzRNvL9T1j-iVX5LG5H3Gg@mail.gmail.com>
 <CAF+90c_rE7DiJ8KEYzFO9GHqx56rin+CiByPe7hRF0fUm-zKBQ@mail.gmail.com>
 <01f2f3da-592b-fd23-709d-ad620422f56d@fleshgrinder.com>
 <CADqTB_jReEH9pGpfKaYnuYiucPcJ7Y+74VL-mNuJJ+THkUFRVA@mail.gmail.com>
 <a6c950d9-9484-a970-3fe4-e03762d108ff@fleshgrinder.com>
 <CADqTB_hd+vL1woB7r2OiNNpCT+2MRthiNw2LzLgjsX1RbbgiHw@mail.gmail.com>
 <402447f2-6007-95c4-6b1d-2bbb30dfdd1d@fleshgrinder.com>
 <CADqTB_hH_kxZNyE1K3ZuKPsy9UkqpfuHCEsDDkOXo5iK9889FQ@mail.gmail.com>
 <35e0c893-435e-d5da-58be-4f63796775b4@fleshgrinder.com>
 <CAGa2bXasv2kx1Zs3=sVDPUyipz-wq8_=tHaG5DmBgb=p=VPzaA@mail.gmail.com>
 <aecfbef4-5f27-af42-52e5-d2133f6be45e@fleshgrinder.com>
 <CAGa2bXb-XnMYqfYLYSWxk5JhtC7Y8=ABjfBL7nx8q55nEzEKcg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>,
 "internals@lists.php.net" <internals@lists.php.net>,
 Rowan Collins <rowan.collins@gmail.com>
Message-ID: <1645f932-f203-56fa-aa0f-f1f20b7c57a5@fleshgrinder.com>
Date: Mon, 31 Oct 2016 00:32:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAGa2bXb-XnMYqfYLYSWxk5JhtC7Y8=ABjfBL7nx8q55nEzEKcg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Allow Iterator to be used with current, next, reset,
 key functions
From: php@fleshgrinder.com (Fleshgrinder)

On 10/31/2016 12:25 AM, Yasuo Ohgaki wrote:
> It depends. Defining specific functions for a task could be bad design
> also. We do design basic functions with flags usually, too.
> 

I know that we have lots of them but they almost always end up in hard
to read and understand I-can-do-everything functions and their
implementation is also cluttered with branching.

On 10/31/2016 12:25 AM, Yasuo Ohgaki wrote:
> That said, dedicated functions for getting first/last key/value sounds
> good to me.
> 
> A agree. That's the reason why I state return value is problem. However,
> 
> if (empty($arr)) {
>   // Do something
> } else {
>   $first = array_first($arr);
> }
> 
> shouldn't be difficult.
> 
> We should raise error for nonsense usage. Programmers have to check
> empty()/isset() all the time anyway.
> 

I am an assert programmer, hence, I have no problem with an error in
such a case if others are fine with it.

@Rowan absolutely right, hence, if really needed:

```
function array_shift_key(array $array);

function array_pop_key(array $array);
```

-- 
Richard "Fleshgrinder" Fussenegger