Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96659
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.176 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <6b228f52-5ad6-0295-62ac-7c1b4b60484a@librelamp.com>
References: <6b228f52-5ad6-0295-62ac-7c1b4b60484a@librelamp.com>
Date: Sun, 30 Oct 2016 19:15:37 +0000
Message-ID: <CAEKnhAHDwwwB6VO9YWiBB=9Oix4+PP8NTKjzq3TKBj1Ngj6z5g@mail.gmail.com>
To: Alice Wonder <alice@librelamp.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c05543a9529bd054019ea69
Subject: Re: [PHP-DEV] 7.1.0RC5 patch
From: bukka@php.net (Jakub Zelenka)

--94eb2c05543a9529bd054019ea69
Content-Type: text/plain; charset=UTF-8

Hey

On Sun, Oct 30, 2016 at 1:22 AM, Alice Wonder <alice@librelamp.com> wrote:

> Hi, first post to list.
>
> LibreSSL user.
>
> PHP 7.1.0RC5 just needs one minor patch to work with LibreSSL, attached
>
> Justification -
>
> X509_get_signature_nid() was introduced in OpenSSL 1.0.2 but LibreSSL fork
> is prior to that.
>
> However (and I don't like this) LibreSSL uses a OPENSSL_VERSION_NUMBER
> defined as 0x20000000L
>
> So have to check for presence of LIBRESSL_VERSION_NUMBER when using
> functions introduced to OpenSSL after the fork (1.0.1h I think)
>
> Tested building against LibreSSL 2.4.3 on a CentOS 7 system (where OpenSSL
> has been completely removed) - 7.1.0RC5 compiles and works with that line
> changed.
>

Hopefully fixed in
https://github.com/php/php-src/commit/1a13809bae9d821783380006de315efcd2b60e61
;)

Thanks

--94eb2c05543a9529bd054019ea69--