Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96650
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54d72d8e-d92e-e546-7e20-728c82760a67@librelamp.com>
References: <44244cfd-c8ad-e0a9-4e70-380a8a8c940c@syberisle.net>
 <CAFMT4Nr+d1k20aY0P9o1G9KU_C9wz2cg2UOPrbE3qbXDBhqe3w@mail.gmail.com>
 <CAF+90c_7g_YdxTfUX8t_OifVJTL=OcvjsC_smWc95M-CcRYaNw@mail.gmail.com>
 <CADqTB_jN6RQxEP5tAJY4T+kuv_rkTzRNvL9T1j-iVX5LG5H3Gg@mail.gmail.com>
 <CAF+90c_rE7DiJ8KEYzFO9GHqx56rin+CiByPe7hRF0fUm-zKBQ@mail.gmail.com>
 <01f2f3da-592b-fd23-709d-ad620422f56d@fleshgrinder.com> <CADqTB_jReEH9pGpfKaYnuYiucPcJ7Y+74VL-mNuJJ+THkUFRVA@mail.gmail.com>
 <54d72d8e-d92e-e546-7e20-728c82760a67@librelamp.com>
Date: Sun, 30 Oct 2016 14:04:31 +0100
Message-ID: <CAF+90c_ONb1HsioiBbLaMGwTVX9VTf5TjqLMLK+UFCtz+TJVNA@mail.gmail.com>
To: Alice Wonder <alice@librelamp.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11468e147845df054014bb28
Subject: Re: [PHP-DEV] Allow Iterator to be used with current, next, reset,
 key functions
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11468e147845df054014bb28
Content-Type: text/plain; charset=UTF-8

On Sun, Oct 30, 2016 at 1:48 PM, Alice Wonder <alice@librelamp.com> wrote:

> On 10/30/2016 05:31 AM, Rasmus Schultz wrote:
>
>> On second thought, I agree with that - changing reset() and end()
>> doesn't make sense, because people know them and expect them to work
>> in a certain way. Likely a lot of people would actually continue to
>> use them with intermediary variables the way they do today.
>>
>
> Today?
>
> In PHP 5.6.x I didn't have to use intermediate variables.
>

You did. You simply suppressed the error in PHP 5. In PHP 7 the error
classification changed, so you're no longer suppressing it. See:
https://3v4l.org/2R8Vp

Prior to the PHP 7 release I suggested marking a number of functions
(array_pop/shift, reset, end) as prefer-ref, so they could be used without
warning, see http://markmail.org/message/peefyi46iz2amdbq. Nothing really
came of it at the time. Just mentioning it here because we can already
avoid the warning right now -- we don't have to drop the IAP first. Both
issues are independent.

However, introducing array_first/last is still better than using reset/end
etc, because these functions can easily trigger an unnecessary array copy,
while array_first/last wouldn't have that problem.

Nikita


>
> Being required to use them was new with PHP 7 and I suspect you will find
> a lot of sites still using pre 7 because they haven't taken the time to
> make sure every app they run works in PHP 7.
>
> All my production servers still run 5.6.x for that reason, I'm only now
> starting to port the apps I can now that it appears the PECL modules I need
> have finally all been updated.
>
> The php apps I am fixing are currently littered with code like this:
>
>
> $SEVENFIX = explode('.', $rs[0]->cover);
> if(end($SEVENFIX) == "whatever") {
>   // do stuff
> }
>
> before trying the app in my 7.1.0RCx test servers they worked just fine as
>
> if(end(explode('.', $rs[0]->cover)) == "whatever") {
>   // do stuff
> }
>
> So I suppose some people might "continue" to use them with intermediary
> but a lot of code that hasn't been ported to 7 doesn't currently.
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a11468e147845df054014bb28--