Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96638
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4Nr+d1k20aY0P9o1G9KU_C9wz2cg2UOPrbE3qbXDBhqe3w@mail.gmail.com>
References: <44244cfd-c8ad-e0a9-4e70-380a8a8c940c@syberisle.net> <CAFMT4Nr+d1k20aY0P9o1G9KU_C9wz2cg2UOPrbE3qbXDBhqe3w@mail.gmail.com>
Date: Sat, 29 Oct 2016 22:06:46 +0200
Message-ID: <CAF+90c_7g_YdxTfUX8t_OifVJTL=OcvjsC_smWc95M-CcRYaNw@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: David Lundgren <dlundgren@syberisle.net>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11479208b24263054006839c
Subject: Re: [PHP-DEV] Allow Iterator to be used with current, next, reset,
 key functions
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11479208b24263054006839c
Content-Type: text/plain; charset=UTF-8

On Fri, Oct 28, 2016 at 2:43 PM, Levi Morrison <levim@php.net> wrote:

> On Wed, Oct 26, 2016 at 7:42 AM, David Lundgren <dlundgren@syberisle.net>
> wrote:
> > Greetings,
> >
> > As suggested by several reviewers of a PR[1] I recently submitted, I'd
> > like to get feedback on letting custom Iterators be used in the current,
> > next, reset, and key functions. If this is something to move forward
> > with, I'll need some help with the RFC process.
> >
> > Recent experiences trying to use these functions with a custom Iterator,
> > and a bug[2], led me to try and fix this. BC will occur when an object
> > implementing Iterator is passed to one of the functions, as the
> > interface methods will be called, instead of returning the objects
> > properties. The old behavior should be maintained for classes that do
> > not implement Iterator.
> >
> > [1] https://github.com/php/php-src/pull/2176
> > [2] https://bugs.php.net/bug.php?id=49369
> >
> > Thanks,
> > Dave
> > --
> > David Lundgren
> > dlundgren@syberisle.net
> > 808.639.0365
> > GPG: 0x26F54D7F
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
>
> I can't seem to recall specifics anymore but I do believe some people
> would greatly prefer to remove the internal array pointer for
> iteration and deprecate these functions. Maybe someone else can
> remember more? Nikita and Bob, maybe?
>

Yeah, I'm one of those people. In PHP 7 the most important user of the IAP,
foreach, was switched to use a more robust mechanism. I believe that at
this point, the concept of an internal array pointer has outlived its
usefulness and we should be working toward removing any APIs that publicly
expose it, including each and the next/current/key family of functions. I
will propose to deprecate each() in particular for PHP 7.2, because it is
both more problematic and more useless than the others, but I'd like to see
the others go away in the long term as well. If people want fine-grained
control over array iteration, they should use an external iterator (aka
ArrayIterator), not an internal one.

Nikita

--001a11479208b24263054006839c--