Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:96633
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.182 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <44244cfd-c8ad-e0a9-4e70-380a8a8c940c@syberisle.net>
References: <44244cfd-c8ad-e0a9-4e70-380a8a8c940c@syberisle.net>
Date: Fri, 28 Oct 2016 06:43:12 -0600
Message-ID: <CAFMT4Nr+d1k20aY0P9o1G9KU_C9wz2cg2UOPrbE3qbXDBhqe3w@mail.gmail.com>
To: David Lundgren <dlundgren@syberisle.net>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Allow Iterator to be used with current, next, reset,
 key functions
From: levim@php.net (Levi Morrison)

On Wed, Oct 26, 2016 at 7:42 AM, David Lundgren <dlundgren@syberisle.net> wrote:
> Greetings,
>
> As suggested by several reviewers of a PR[1] I recently submitted, I'd
> like to get feedback on letting custom Iterators be used in the current,
> next, reset, and key functions. If this is something to move forward
> with, I'll need some help with the RFC process.
>
> Recent experiences trying to use these functions with a custom Iterator,
> and a bug[2], led me to try and fix this. BC will occur when an object
> implementing Iterator is passed to one of the functions, as the
> interface methods will be called, instead of returning the objects
> properties. The old behavior should be maintained for classes that do
> not implement Iterator.
>
> [1] https://github.com/php/php-src/pull/2176
> [2] https://bugs.php.net/bug.php?id=49369
>
> Thanks,
> Dave
> --
> David Lundgren
> dlundgren@syberisle.net
> 808.639.0365
> GPG: 0x26F54D7F
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

I can't seem to recall specifics anymore but I do believe some people
would greatly prefer to remove the internal array pointer for
iteration and deprecate these functions. Maybe someone else can
remember more? Nikita and Bob, maybe?